New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCOCOA-2285: Wire up the new progress notifications #8492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall everything looks pretty good on initial review. I left some comments and some questions. I guess this is missing some more testing but I do think the API is so simple there is not much to test here, but to test it against flexible sync.
RealmSwift/Sync.swift
Outdated
|
||
Whenever the progress reporting mode is `forCurrentlyOutstandingWork`, that value | ||
will monotonically increase until it reaches 1.0. If the progress mode is `reportIndefinitely`, the | ||
value will monotonically increase until it reaches 1.0, but may subsequently decrease if new server data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if there is a download/upload while another download/upload happens?, wouldn't that mean that in some cases the value will not increase monotonically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. good question, I'll try and investigate this.
2c4e1ff
to
bec6712
Compare
f7c035b
to
3be4e19
Compare
f02a75a
to
45667bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor comments
The CI failures seem to be github related (502s). |
This is based on a branch that is the result of merging #8539 and master. Will rebase once #8539 is merged. It depends on an unreleased Core version, so most of the workflows will fail.
Fixes #8476