Fix some static analyzer warnings #8249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/static-analyzer
branch
from
d35ea12
to
2026f37
Compare
dianaafanador3
approved these changes
May 30, 2023
| @@ -11,6 +12,10 @@ Replace Xcode 14.3 binaries with 14.3.1, which has important bug fixes for Swift | |||
| ### Fixed | |||
| * Allow support for implicit boolean queries on Swift's Type Safe Queries API | |||
| ([#8212](https://github.com/realm/realm-swift/issues/8212)). | |||
| * `-[RLMAsymmetricObject createObject:withValue:]` was marked as having a | |||
| non-null return value despite always returning `nil` (since v10.29.0). | |||
| * Eliminate several clang static analyzer warnings which did not report actual | |||
There was a problem hiding this comment.
Can you tag the issue which reported this?
| } | ||
|
|
||
| if constexpr (is_any_v<C, Columns<Dictionary>> && is_any_v<T, Columns<StringData>, Columns<BinaryData>>) { | ||
| // Core only implements these for Columns<Mixed> due to Dictionary being Mixed internall |
There was a problem hiding this comment.
Suggested change
| // Core only implements these for Columns<Mixed> due to Dictionary being Mixed internall | |
| // Core only implements these for Columns<Mixed> due to Dictionary being Mixed internal |
| do_add_diacritic_sensitive_string_constraint(operatorType, predicateOptions, std::forward<C>(column), value); | ||
| } | ||
|
|
||
| if constexpr (is_any_v<C, Columns<Dictionary>> && is_any_v<T, Columns<StringData>, Columns<BinaryData>>) { |
There was a problem hiding this comment.
Can we just check if T is mixed and throw otherwise
| @@ -1603,6 +1603,10 @@ - (void)testConvertToEmbeddedAddingMoreLinks { | |||
| XCTAssertNotNil(oldObject); | |||
| XCTAssertNotNil(newObject); | |||
| RLMObject *childObject = newObject[@"object"]; | |||
| XCTAssertNotNil(childObject); | |||
| if (childObject == nil) { | |||
There was a problem hiding this comment.
If the above assertion fails, is this even run?
There was a problem hiding this comment.
Yes. The rest of the test continues running even if an XCTest assertion fails.
tgoyne
force-pushed
the
tg/static-analyzer
branch
from
2026f37
to
eb472ea
Compare
tgoyne
force-pushed
the
tg/static-analyzer
branch
from
eb472ea
to
fef2fec
Compare
LowAmmo
approved these changes
Aug 29, 2023
|
Was just about to start making similar changes when I saw this PR! Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.