Fix CI issues and warnings

Realm/RLMConstants.h

@@ -58,7 +58,7 @@ RLM_HEADER_AUDIT_BEGIN(nullability, sendability)
 /**
  `RLMPropertyType` is an enumeration describing all property types supported in Realm models.
 
- For more information, see [Realm Models](https://www.mongodb.com/docs/realm/sdk/swift/fundamentals/object-models-and-schemas/).
+ For more information, see [Realm Models](https://www.mongodb.com/docs/atlas/device-sdks/sdk/swift/model-data/object-models/).
  */
 typedef RLM_CLOSED_ENUM(int32_t, RLMPropertyType) {
 
@@ -89,12 +89,17 @@ typedef RLM_CLOSED_ENUM(int32_t, RLMPropertyType) {
 
 #pragma mark - Linked object types
 
- /** Realm model objects. See [Realm Models](https://www.mongodb.com/docs/realm/sdk/swift/fundamentals/object-models-and-schemas/) for more information. */
+ /** Realm model objects. See [Realm Models](https://www.mongodb.com/docs/atlas/device-sdks/sdk/swift/model-data/object-models/) for more information. */
  RLMPropertyTypeObject = 7,
- /** Realm linking objects. See [Realm Models](https://www.mongodb.com/docs/realm/sdk/swift/fundamentals/relationships/#inverse-relationship) for more information. */
+ /** Realm linking objects. See [Realm Models](https://www.mongodb.com/docs/atlas/device-sdks/sdk/swift/model-data/relationships/#define-an-inverse-relationship-property) for more information. */
  RLMPropertyTypeLinkingObjects = 8,
 };
 
+/**
+ `RLMAnyValueType` is an enumeration describing all property types supported by RLMValue (AnyRealmValue).
+
+ For more information, see [Realm Models](https://www.mongodb.com/docs/atlas/device-sdks/sdk/swift/model-data/supported-types/#std-label-ios-anyrealmvalue-data-type).
+ */
 typedef RLM_CLOSED_ENUM(int32_t, RLMAnyValueType) {
 #pragma mark - Primitive types
  /** Integers: `NSInteger`, `int`, `long`, `Int` (Swift) */

Realm/RLMManagedArray.mm

@@ -202,13 +202,13 @@ - (id)objectAtIndex:(NSUInteger)index {
  realm::Mixed value = _backingList.get_any(index);
  RLMAccessorContext context(*_ownerInfo, *_objectInfo, _property);
  if (value.is_type(realm::type_Dictionary)) {
- return context.box(_backingList.get_dictionary(index));
+ return context.box(_backingList.get_dictionary(realm::PathElement{(int)index}));
  }
  else if (value.is_type(realm::type_List)) {
- return context.box(_backingList.get_list(index));
+ return context.box(_backingList.get_list(realm::PathElement{(int)index}));
  }
  else {
- return context.box(value);
+ return _backingList.get(context, index);
  }
  });
 }

Realm/RLMManagedDictionary.mm

@@ -253,10 +253,10 @@ - (nullable id)objectForKey:(id)key {
  RLMAccessorContext context(*_ownerInfo, *_objectInfo, _property);
  if (auto value = _backingCollection.try_get_any(context.unbox<realm::StringData>(key))) {
  if (value->is_type(realm::type_Dictionary)) {
- return context.box(_backingCollection.get_dictionary(context.unbox<realm::StringData>(key)));
+ return context.box(_backingCollection.get_dictionary(realm::PathElement{context.unbox<realm::StringData>(key)}));
  }
  else if (value->is_type(realm::type_List)) {
- return context.box(_backingCollection.get_list(context.unbox<realm::StringData>(key)));
+ return context.box(_backingCollection.get_list(realm::PathElement{context.unbox<realm::StringData>(key)}));
  }
  else {
  return context.box(*value);

Realm/RLMQueryUtil.mm

@@ -1688,7 +1688,9 @@ bool is_self_value_for_key_path_function_expression(NSExpression *expression)
 
  NSString *keyPath;
  NSExpression *keyPathExpression = functionExpression;
- for (int i = 0; i < pathElements.size(); i++) {
+
+ // We consider only `NSKeyPathExpressionType` values to build the keypath.
+ for (unsigned long i = 0; i < pathElements.size(); i++) {
  if (keyPathExpression.arguments[0].expressionType == NSKeyPathExpressionType) {
  keyPath = [NSString stringWithFormat:@"%@", keyPathExpression.arguments[0]];
  } else {
@@ -1858,7 +1860,7 @@ bool is_self_value_for_key_path_function_expression(NSExpression *expression)
 // This will iterate each argument of the NSExpression and its nested NSExpression's and take the constant value
 // and create a PathElement for the query.
 void QueryBuilder::get_path_elements(std::vector<PathElement> &paths, NSExpression *expression) {
- for (int i = 0; i < expression.arguments.count; i++) {
+ for (NSUInteger i = 0; i < expression.arguments.count; i++) {
  if (expression.arguments[i].expressionType == NSFunctionExpressionType) {
  get_path_elements(paths, expression.arguments[i]);
  } else {

Realm/RLMValue.mm

@@ -23,9 +23,12 @@
 
 @implementation NSData (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeData;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeData;
@@ -37,9 +40,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSDate (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeDate;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeDate;
@@ -51,6 +57,8 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSNumber (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  if ([self objCType][0] == 'c' && (self.intValue == 0 || self.intValue == 1)) {
  return RLMPropertyTypeBool;
@@ -68,6 +76,7 @@ - (RLMPropertyType)rlm_valueType {
  @throw RLMException(@"Unknown numeric type on type RLMValue.");
  }
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
 #pragma clang diagnostic push
@@ -82,9 +91,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSNull (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeAny;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeAny;
@@ -96,9 +108,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSString (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeString;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeString;
@@ -110,9 +125,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSUUID (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeUUID;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeUUID;
@@ -124,9 +142,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation RLMDecimal128 (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeDecimal128;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeDecimal128;
@@ -138,9 +159,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation RLMObjectBase (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeObject;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeObject;
@@ -152,9 +176,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation RLMObjectId (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  return RLMPropertyTypeObjectId;
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeObjectId;
@@ -166,9 +193,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSDictionary (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  REALM_UNREACHABLE();
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeDictionary;
@@ -178,9 +208,12 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation RLMDictionary (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  REALM_UNREACHABLE();
 }
+#pragma clang diagnostic pop
 
 - (RLMAnyValueType)rlm_anyValueType {
  return RLMAnyValueTypeDictionary;
@@ -192,6 +225,8 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation NSArray (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  REALM_UNREACHABLE();
 }
@@ -204,6 +239,8 @@ - (RLMAnyValueType)rlm_anyValueType {
 
 @implementation RLMArray (RLMValue)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 - (RLMPropertyType)rlm_valueType {
  REALM_UNREACHABLE();
 }

Realm/Tests/RLMValueTests.m

@@ -19,12 +19,6 @@
 #import "RLMTestCase.h"
 #import <Realm/RLMValue.h>
 
-@interface NotRealmObject : NSObject
-@end
-
-@implementation NotRealmObject
-@end
-
 @interface RLMValueTests : RLMTestCase
 @end
 
@@ -871,18 +865,14 @@ - (void)testDeleteAndUpdateValuesInManagedDictionary {
 }
 
 - (void)testDeleteAndUpdateValuesInArray {
- RLMRealm *r = [self realmWithTestPath];
- StringObject *so = [[StringObject alloc] init];
- so.stringCol = @"hello";
- RLMObjectId *oid = [RLMObjectId objectId];
- NSDate *d = [NSDate date];
  NSArray *d1 = @[ @"hello2",
  @YES];
  NSArray *d2 = @[@"hello"];
  MixedObject *mo = [[MixedObject alloc] init];
  mo.anyCol = d1;
  [mo.anyArray addObjects:@[d1, d2]];
 
+ RLMRealm *r = [self realmWithTestPath];
  [r beginWriteTransaction];
  [r addObject:mo];
  [r commitWriteTransaction];

Realm/Tests/SectionedResultsTests.m

@@ -168,24 +168,24 @@ - (NSDictionary *)keyPathsAndValues {
 }
 
 - (id<RLMValue>)sectionKeyForValue:(id<RLMValue>)value {
- switch (value.rlm_valueType) {
- case RLMPropertyTypeInt:
+ switch (value.rlm_anyValueType) {
+ case RLMAnyValueTypeInt:
  return [NSNumber numberWithInt:(((NSNumber *)value).intValue % 2)];
- case RLMPropertyTypeBool:
+ case RLMAnyValueTypeBool:
  return value;
- case RLMPropertyTypeFloat:
+ case RLMAnyValueTypeFloat:
  return [(NSNumber *)value isEqualToNumber:@(1.1f * 1)] ? @(1.1f) : @(2.2f);
- case RLMPropertyTypeDouble:
+ case RLMAnyValueTypeDouble:
  return [(NSNumber *)value isEqualToNumber:@(1.11 * 1)] ? @(1.11) : @(2.2);
- case RLMPropertyTypeString:
+ case RLMAnyValueTypeString:
  return [(NSString *)value substringToIndex:1];
- case RLMPropertyTypeDate: {
+ case RLMAnyValueTypeDate: {
  NSCalendar *calendar = [NSCalendar currentCalendar];
  [calendar setTimeZone:[NSTimeZone timeZoneForSecondsFromGMT:0]];
  NSDateComponents *comp = [calendar components:NSCalendarUnitWeekday fromDate:(NSDate *)value];
  return [NSNumber numberWithInteger:(NSInteger)comp.weekday];
  }
- case RLMPropertyTypeDecimal128:
+ case RLMAnyValueTypeDecimal128:
  switch ((int)((RLMDecimal128 *)value).doubleValue) {
  case 1:
  return @"one";
@@ -196,15 +196,15 @@ - (NSDictionary *)keyPathsAndValues {
  default:
  XCTFail();
  }
- case RLMPropertyTypeUUID:
+ case RLMAnyValueTypeUUID:
  if ([(NSUUID *)value isEqual:[[NSUUID alloc] initWithUUIDString:@"00000000-0000-0000-0000-000000000000"]]) {
  return @"a";
  } else if ([(NSUUID *)value isEqual:[[NSUUID alloc] initWithUUIDString:@"137DECC8-B300-4954-A233-F89909F4FD89"]]) {
  return @"b";
  } else if ([(NSUUID *)value isEqual:[[NSUUID alloc] initWithUUIDString:@"b84e8912-a7c2-41cd-8385-86d200d7b31e"]]) {
  return @"c";
  }
- case RLMPropertyTypeAny:
+ case RLMAnyValueTypeAny:
  return [NSNumber numberWithInt:(((NSNumber *)value).intValue % 2)];;
  default:
  XCTFail();

RealmSwift/Tests/MixedCollectionTest.swift

@@ -23,7 +23,7 @@ class MixedCollectionTest: TestCase {
  func testAnyMixedDictionary() throws {
  let so = SwiftStringObject()
  so.stringCol = "hello"
- let d = Date.now
+ let d = Date()
  let oid = ObjectId.generate()
  let uuid = UUID()
 
@@ -222,7 +222,7 @@ class MixedCollectionTest: TestCase {
  func testAnyMixedList() throws {
  let so = SwiftStringObject()
  so.stringCol = "hello"
- let d = Date.now
+ let d = Date()
  let oid = ObjectId.generate()
  let uuid = UUID()