Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial subscriptions callback #732

Draft
wants to merge 172 commits into
base: main
Choose a base branch
from
Draft

Initial subscriptions callback #732

wants to merge 172 commits into from

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Jul 30, 2022 •
edited

Fixes #739
Done:

@desistefanova desistefanova self-assigned this Jul 30, 2022
@cla-bot cla-bot bot added the cla: yes label Jul 30, 2022
@desistefanova desistefanova changed the base branch from master to ds/open_realm_async July 30, 2022 22:01
desistefanova and others added 22 commits August 11, 2022 11:57
@desistefanova
Merge branch 'master' into ds/open_realm_async
4dad19f
@desistefanova
Rename _openRealmAsyncCallback
4c0f6c3
@desistefanova
Remove Realm.openSync
9e73ed2
@desistefanova
Cancel operation realm open asyn
c801ccf
@desistefanova
Create RealmAsyncTask
c0c1f03
@desistefanova
Fix test
ae34d95
@desistefanova
Delete not needed imports
99f56e8
@desistefanova
Merge branch 'master' into ds/open_realm_async
fc2862f
@desistefanova
Merge branch 'master' into ds/open_realm_async
8b3f340
@desistefanova
Rename class RealmAsyncOpenTask
929f308
@desistefanova
Implement cancel and onProgress
78a362e
@desistefanova
Add API doc
18aa548
@desistefanova
Fix API doc
1f2403f
@desistefanova
Update CHANGELOG.md
640eece
@desistefanova
Merge branch 'master' into ds/open_realm_async
ad31355
@desistefanova
Fix removed handle from RealmAsyncOpenTask
c0c88eb
@desistefanova
open async many times exception
427501b
@desistefanova
Delete package dart async
49ff150
@desistefanova
Merge branch 'master' into ds/open_realm_async
3e12460
@desistefanova
Regenerate bindings
1a8b7d4
@desistefanova
Merge branch 'ds/open_realm_async' into ds/initial_subscriptions
06ea3cf
@desistefanova
Implement RealmCancelationController
a0ab6cf
@desistefanova desistefanova marked this pull request as draft October 13, 2022 15:07
@desistefanova desistefanova marked this pull request as ready for review October 13, 2022 19:01
@blagoev blagoev marked this pull request as draft October 18, 2022 11:00
Base automatically changed from ds/open_realm_async to master October 18, 2022 13:41
@coveralls
Copy link

coveralls commented Oct 18, 2022 •
edited

Pull Request Test Coverage Report for Build 3283811918

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 87.871%
Totals Coverage Status
Change from base Build 3273943496: -0.6%
Covered Lines: 2101
Relevant Lines: 2391
💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review October 18, 2022 17:16
blagoev
blagoev suggested changes Oct 19, 2022
View reviewed changes
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/realm_class.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Show resolved Hide resolved
nirinchev
nirinchev requested changes Oct 19, 2022
View reviewed changes
lib/src/realm_class.dart Outdated Show resolved Hide resolved
@desistefanova desistefanova marked this pull request as draft October 19, 2022 13:43
@desistefanova desistefanova mentioned this pull request Jun 23, 2023
Closed
@nicola-cab nicola-cab mentioned this pull request Jun 23, 2023
Merged
3 tasks
@erdzan12 erdzan12 mentioned this pull request Sep 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgoyne tgoyne tgoyne left review comments

@nirinchev nirinchev nirinchev requested changes

@nielsenko nielsenko Awaiting requested review from nielsenko

@blagoev blagoev Awaiting requested review from blagoev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial subscriptions callback
5 participants
@desistefanova @coveralls @tgoyne @nirinchev @blagoev