Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-930: Refactor handles #1550

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open

RDART-930: Refactor handles #1550

wants to merge 71 commits into from

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Mar 11, 2024

Split and refactoring complete.

   wc -l file
       2 ./convert_native.dart
       4 ./ffi.dart
      22 ./query_handle.dart
      22 ./scheduler_handle.dart
      24 ./convert.dart
      24 ./realm_library.dart
      28 ./subscription_handle.dart
      35 ./notification_token_handle.dart
      55 ./map_changes_handle.dart
      70 ./error_handling.dart
      78 ./collection_changes_handle.dart
      80 ./async_open_task_handle.dart
      81 ./subscription_set_handle.dart
      82 ./credentials_handle.dart
      85 ./rooted_handle.dart
      90 ./mutable_subscription_set_handle.dart
      90 ./schema_handle.dart
      93 ./handle_base.dart
     117 ./results_handle.dart
     132 ./set_handle.dart
     142 ./decimal128.dart
     146 ./list_handle.dart
     164 ./session_handle.dart
     172 ./to_native.dart
     191 ./realm_core.dart
     200 ./map_handle.dart
     207 ./object_handle.dart
     268 ./config_handle.dart
     354 ./user_handle.dart
     358 ./from_native.dart
     461 ./realm_handle.dart
     592 ./app_handle.dart
   13407 ./realm_bindings.dart

Fixes: #1479

@cla-bot cla-bot bot added the cla: yes label Mar 11, 2024
@nielsenko nielsenko changed the base branch from main to kn/xcode-15 March 11, 2024 20:12
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 2 times, most recently from d34879b to 2e43af9 Compare March 11, 2024 20:55
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 3 times, most recently from 921d00f to aaf0823 Compare March 22, 2024 16:40
@nielsenko nielsenko changed the base branch from kn/xcode-15 to main March 22, 2024 16:44
Copy link

coveralls-official bot commented Apr 12, 2024

Pull Request Test Coverage Report for Build 9004258828

Details

  • 2028 of 2203 (92.06%) changed or added relevant lines in 47 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 86.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/realm_dart/lib/src/map.dart 21 22 95.45%
packages/realm_dart/lib/src/native/collection_changes_handle.dart 20 21 95.24%
packages/realm_dart/lib/src/native/collection_handle_base.dart 16 17 94.12%
packages/realm_dart/lib/src/native/convert.dart 5 6 83.33%
packages/realm_dart/lib/src/session.dart 10 11 90.91%
packages/realm_dart/lib/src/set.dart 14 15 93.33%
packages/realm_dart/lib/src/credentials.dart 16 18 88.89%
packages/realm_dart/lib/src/native/realm_library.dart 6 8 75.0%
packages/realm_dart/lib/src/native/results_handle.dart 47 49 95.92%
packages/realm_dart/lib/src/realm_object.dart 31 33 93.94%
Files with Coverage Reduction New Missed Lines %
packages/realm_dart/lib/src/subscription.dart 1 90.0%
Totals Coverage Status
Change from base Build 9001128643: 0.1%
Covered Lines: 5874
Relevant Lines: 6772

💛 - Coveralls

@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 9 times, most recently from 5f03272 to a8cecc6 Compare April 13, 2024 21:05
@nielsenko nielsenko added the no-changelog Used to skip the changelog check label Apr 15, 2024
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 4 times, most recently from 5ca0803 to bfd85df Compare April 17, 2024 08:29
@nielsenko nielsenko force-pushed the kn/refactor-handles-2 branch 5 times, most recently from 4a1a398 to 342a450 Compare April 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-factor realm_core.dart into handle specific files
3 participants