Flexible sync subscribe/unsubscribe API #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desistefanova
changed the title
Pull Request Test Coverage Report for Build 6867176225
💛 - Coveralls |
nielsenko
reviewed
Aug 16, 2023
| @@ -34,7 +34,7 @@ import 'session.dart'; | |||
| import 'subscription.dart'; | |||
| import 'set.dart'; | |||
|
|
|||
| export 'package:cancellation_token/cancellation_token.dart' show CancellationToken, CancelledException; | |||
| export 'package:cancellation_token/cancellation_token.dart' show CancellationToken, TimeoutCancellationToken, CancelledException; | |||
There was a problem hiding this comment.
Still now fan of exporting classes from other packages.. but I know you didn't start this 😄
| @@ -272,21 +273,22 @@ class MutableSubscriptionSet extends SubscriptionSet { | |||
| return Subscription._(realmCore.insertOrAssignSubscription(this, query, name, update)); | |||
| } | |||
|
|
|||
| /// Remove the [subscription] from the set, if it exists. | |||
| /// Removes the [subscription] from the set, if it exists. | |||
There was a problem hiding this comment.
Why change the tense? If we do, there are doc comments on other methods like clear that should change as well..
There was a problem hiding this comment.
Most of the descriptions in this file are like this, Removes, Gets, Adds ... I will change the rest of the methods in the file.
nirinchev
added a commit
that referenced
this pull request
Nov 30, 2023
* main: Don't add the ISRG X1 Root on Android (#1434) Wait for initial sync to complete before starting the tests (#1435) kn/update analyzer (#1365) Add vNext Changelog header (#1429) [Release 1.6.0] (#1428) Upgrade to Core 13.23.4 (#1427) Flexible sync subscribe/unsubscribe API (#1354) Use default context rather than creating a new one (#1426) Handle duplicate certificates (#1425) kn/add certificate (#1378) asymmetric object allow non embedded links (#1402) Rudimentary geospatial support (#1389) Core 13.20.1 sync errors changes (#1387) Fix RealmObject.hashCode (#1420) add 'ignore_for_file: type=lint' to *.g.dart files (#1413) kn/fix skip then iterate bug (#1410)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
RealmResults.subscribe()andRealmResults.unsubscribe()andMutableSubscriptionSet.clear({bool unnamedOnly = false}).Adds cancellationToken parameter to
Session.waitForDownload(),Session.waitForUpload()andSubscriptionSet.waitForSynchronization()Fixes #1353
Related to realm/realm-kotlin#1356, realm/realm-js#5772, realm/realm-swift#7755, realm/realm-swift#8244