Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5461 added ib_segue_action case in TypeContent #5524

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

#5461 added ib_segue_action case in TypeContent #5524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
803ff89
#5461 added ib_segue_action case in TypeContent
dk-talks Apr 2, 2024
50c2c2b
Merge branch 'realm:main' into dk-talks-add_TypeContent_ib_segue_action
dk-talks Apr 2, 2024
a06e53c
implemented ibSegueAction similar to ibAction
dk-talks Apr 3, 2024
8ee51af
Added Missed Comma
dk-talks Apr 6, 2024
e35d7c3
Updated test reference and removed ibSegueAction
dk-talks Apr 8, 2024
7662095
Merge branch 'realm:main' into dk-talks-add_TypeContent_ib_segue_action
dk-talks Apr 8, 2024
1dadc49
Updated Test reference for ib_segue_action
dk-talks Apr 9, 2024
e79276a
Updated test configuration for ib_segue_action
dk-talks Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/SwiftLintBuiltInRules/Rules/Lint/UnusedDeclarationRule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ private let declarationKindsToSkip: Set<SwiftDeclarationKind> = [
]

private let declarationAttributesToSkip: Set<SwiftDeclarationAttributeKind> = [
.ibsegueaction,
.ibaction,
.main,
.nsApplicationMain,
Expand Down
1 change: 1 addition & 0 deletions Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/TypeContentsOrderConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ enum TypeContent: String {
case otherMethod = "other_method"
case `subscript` = "subscript"
case deinitializer = "deinitializer"
case ibSegueAction = "ib_segue_action"
}

@AutoApply
Expand Down
3 changes: 3 additions & 0 deletions Source/SwiftLintBuiltInRules/Rules/Style/TypeContentsOrderRule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ struct TypeContentsOrderRule: OptInRule {
if typeContentStructure.enclosedSwiftAttributes.contains(SwiftDeclarationAttributeKind.ibaction) {
return .ibAction
}
if typeContentStructure.enclosedSwiftAttributes.contains(SwiftDeclarationAttributeKind.ibsegueaction) {
return .ibSegueAction
}
return .otherMethod

case .functionSubscript:
Expand Down
1 change: 1 addition & 0 deletions Source/SwiftLintCore/Extensions/SwiftDeclarationAttributeKind+Swiftlint.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public extension SwiftDeclarationAttributeKind {
.nonobjc,
.objcMembers,
.ibaction,
.ibsegueaction,
.iboutlet,
.ibdesignable,
.ibinspectable,
Expand Down