Disable Straddled Joins by default

Out of an abundance of caution, we are also disabling this by default for now. We don't, however, have any examples of issues with this feature. This is also a partial revert of Iad455b26. We again pass the argument explicitly as we did before the change that made this feature enabled by default. Change-Id: I5b79cf656e5e161ba9e2d7c3013541d6d560a7d9 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/8025 Reviewed-by: Michael Zink <[email protected]> Tested-by: Buildkite CI
readysettech · Sep 19, 2024 · ae9c3fc · ae9c3fc
1 parent 3a7a266
commit ae9c3fc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/readyset-features.json b/readyset-features.json
@@ -37,7 +37,7 @@
         "command-line": "--feature-straddled-joins",
         "environment-variable": "FEATURE_STRADDLED_JOINS",
         "description": "Enable support for straddled joins (joins with partial keys traced to both parents).",
-        "default": true
+        "default": false
     },
     {
         "feature_id": "6",

diff --git a/readyset-server/src/lib.rs b/readyset-server/src/lib.rs
@@ -668,7 +668,7 @@ pub struct WorkerOptions {
     #[arg(
         long,
         env = "FEATURE_STRADDLED_JOINS",
-        default_value = "true",
+        default_value = "false",
         default_missing_value = "true",
         num_args = 0..=1,
         action = ArgAction::Set,

diff --git a/system-benchmarks/benches/workload.rs b/system-benchmarks/benches/workload.rs
@@ -644,6 +644,7 @@ fn start_adapter(args: SystemBenchArgs) -> anyhow::Result<()> {
         "standalone",
         "--allow-unauthenticated-connections",
         "--feature-post-lookup",
+        "--feature-straddled-joins",
         "--upstream-db-url",
         &upstream_url,
         "--durability",