feat(python): add ASGI support (Django) #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 I left one small comment about the added dependency and there's a merge conflict that will need to be resolved. I've asked some other teammates to take a look and review. |
llimllib
reviewed
Oct 30, 2024
llimllib
reviewed
Oct 30, 2024
llimllib
approved these changes
Oct 31, 2024
azinder1
approved these changes
Oct 31, 2024
packages/python/requirements.txt
Outdated
| Werkzeug==3.0.4 | ||
| uvicorn==0.32.0 |
There was a problem hiding this comment.
I looked a bit into uvicorn and it seems like it's commonly used (like with FastAPI), but just want to check that it's necessary since it does add another dependency so it should be vetted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| :------------------- |
🧰 Changes
Added ASGI support in Python package, support for synchronous and asynchronous projects.
🧬 QA & Testing
Aligned unit tests to ASGI/WSGI, async/sync operations & typings.
Integration tests are split into 2 parts (ASGI/WSGI).