Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): fireAndForget was not respected #1002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(node): fireAndForget was not respected #1002

wants to merge 1 commit into from

Conversation

mothershipper
Copy link

@mothershipper mothershipper commented May 30, 2024 •
edited
Loading

🚥 Resolves Unfiled Issue

🧰 Changes

fireAndForget was not being passed through to the api call site.

See #1001 for context

🧬 QA & Testing

@mothershipper mothershipper changed the title fix(node): fireAndForget should be passed through fix(node): fireAndForget was not respected May 30, 2024
@mothershipper mothershipper mentioned this pull request May 30, 2024
Open
@mothershipper
fix(node): fireAndForget should be passed through
0b61fe9 
The fireAndForget setting was not being passed through to the API call
site.
@kanadgupta kanadgupta added the node Issues related to our Node SDK label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
node Issues related to our Node SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mothershipper @kanadgupta