Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): prevent node crash on uncaught exception #1001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(node): prevent node crash on uncaught exception #1001

wants to merge 1 commit into from

Commits on May 30, 2024

  1. fix(node): prevent node crash on uncaught exception 

    When fire-and-forget is set, the request promise isn't returned to the log
handler, meaning the [catch here](https://github.com/readmeio/metrics-sdks/blob/main/packages/node/src/lib/log.ts#L28-L31)
doesn't prevent node from exiting on a request failure.
    @mothershipper
    mothershipper committed May 30, 2024
    Configuration menu
    Copy the full SHA
    8d7d864 View commit details
    Browse the repository at this point in the history