fix: migrate tables with html #1005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
force-pushed
the
fix/migrate-tables-with-html
branch
from
36a843e
to
36bae34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes migrating tables with html.
We're doing some shenanigans with table cells so that they support block content. We basically reparse each cell as if it's a root markdown doc and then re-insert it into the tree.
This adds block level html as a condition for wrapping said content in a paragraph. Wrapping it in a paragraph seems to be required to get remark to compile newlines correctly. 🤷
🧬 QA & Testing