Merge branch 'next'

readmeio · Oct 3, 2024 · 086c406 · 086c406
2 parents 77be1a3 + 0db3627
commit 086c406
Show file tree

Hide file tree

Showing 8 changed files with 42 additions and 3 deletions.
diff --git a/...l-regression-tests-rdmd-syntax-renders-image-tests-without-surprises-1-snap.png b/...l-regression-tests-rdmd-syntax-renders-image-tests-without-surprises-1-snap.png
diff --git a/...-visual-regression-tests-rdmd-syntax-renders-lists-without-surprises-1-snap.png b/...-visual-regression-tests-rdmd-syntax-renders-lists-without-surprises-1-snap.png
diff --git a/__tests__/browser/markdown.test.js b/__tests__/browser/markdown.test.js
@@ -20,6 +20,7 @@ describe('visual regression tests', () => {
       //'features',
       'headings',
       'images',
+      'imageTests',
       'lists',
       'mdxComponents',
       'tables',

diff --git a/components/Accordion/index.tsx b/components/Accordion/index.tsx
@@ -8,7 +8,7 @@ const Accordion = ({ children, icon, iconColor, title }) => {
   return (
     <details className="Accordion" onToggle={() => setIsOpen(!isOpen)}>
       <summary className="Accordion-title">
-        <i className={`Accordion-toggleIcon${isOpen ? '_opened' : ''} <i class="fa fa-regular fa-chevron-right"></i>`}></i>
+        <i className={`Accordion-toggleIcon${isOpen ? '_opened' : ''} fa fa-regular fa-chevron-right`}></i>
         {icon && <i className={`Accordion-icon fa-duotone fa-solid ${icon}`} style={{ color: `${iconColor}` }}></i>}
         {title}
       </summary>

diff --git a/components/Accordion/style.scss b/components/Accordion/style.scss
@@ -38,7 +38,7 @@
 
   &-toggleIcon,
   &-toggleIcon_opened {
-    color: var(--color-text-default, #384248);
+    color: var(--color-text-minimum, #637288);
     font-size: 14px;
     margin-left: 5px;
     margin-right: 10px;

diff --git a/components/Image/index.tsx b/components/Image/index.tsx
@@ -58,7 +58,7 @@ const Image = (Props: ImageProps) => {
     setLightbox(!lightbox);
   };
 
-  if (caption) {
+  if (children || caption) {
     return (
       <figure>
         <span

diff --git a/docs/image-tests.mdx b/docs/image-tests.mdx
@@ -0,0 +1,35 @@
+We're excited you're here! :blue_heart:
+
+<Image src="https://owlbertsio-resized.s3.amazonaws.com/Blocks.psd.full.png">
+  Owlbert!
+</Image>
+
+<Table align={["left","left","left"]}>
+  <thead>
+    <tr>
+      <th style={{ textAlign: "left" }} />
+
+      <th style={{ textAlign: "left" }} />
+
+      <th style={{ textAlign: "left" }} />
+    </tr>
+  </thead>
+
+  <tbody>
+    <tr>
+      <td style={{ textAlign: "left" }} />
+
+      <td style={{ textAlign: "left" }} />
+
+      <td style={{ textAlign: "left" }} />
+    </tr>
+
+    <tr>
+      <td style={{ textAlign: "left" }} />
+
+      <td style={{ textAlign: "left" }} />
+
+      <td style={{ textAlign: "left" }} />
+    </tr>
+  </tbody>
+</Table>
diff --git a/example/docs.ts b/example/docs.ts
@@ -17,6 +17,8 @@ import headings from '../docs/headings.md';
 // @ts-ignore
 import images from '../docs/images.md';
 // @ts-ignore
+import imageTests from '../docs/image-tests.mdx';
+// @ts-ignore
 import lists from '../docs/lists.md';
 // @ts-ignore
 import mdxComponents from '../docs/mdx-components.mdx';
@@ -42,6 +44,7 @@ const fixtures = Object.entries({
   gettingStarted,
   headings,
   images,
+  imageTests,
   lists,
   mdxComponents,
   sanitizingTests,