[MSI] CORE-18707 workaround. Allow MSI under ROS amd64 to continue when GetSystemWow64DirectoryW is called #6887

julenuri · 2024-05-14T19:07:42Z

[MSI] CORE-18707 hack. Allow MSI under ROS amd64 to continue when GetSystemWow64DirectoryW is called

Purpose

Workaround (with a hack) a temporary situation since we have the WOW64 unimplemented (neither GetSystemWow64DirectoryW).

JIRA issue: CORE-18707

Proposed changes

Temporary workaround that avoids MSI to continue under our ROS Amd64.

TODO

Once merged, be careful in the future if the thing goes implemented.

dll/win32/msi/custom.c

HBelusca

forgotten changes there too.

dll/win32/msi/custom.c

JoachimHenze

Approved, although it is a workaround. But if it helps you guys for now, why not. Thanks for using the preprocessor to make sure, that it definitely won't break anything for 32bit builds. Thumbs up.

dll/win32/msi/custom.c

…SystemWow64DirectoryW is called [MSI] Fix minor indentation and spaces before brackets. [MSI] Minor fixes and correctly reporting ERR instead of WARN [MSI] Fixing a warning and the whitespaces [MSI] Minor fix whitespaces

learn-more

Not a big fan of the java style braces, but there's been too much whitespace nitpicking on this PR already.

cbialorucki · 2024-05-23T02:29:37Z

dll/win32/msi/custom.c

+ get_binary_type(binary->tmpfile, &arch);
+ if (arch == SCS_32BIT_BINARY) {
+ ERR("%s is a 32 bit custom action. Returning as ERROR_SUCCESS\n", debugstr_w(source));
+ return ERROR_SUCCESS; // NO WOW64! return as executed though it's not true


Suggested change

return ERROR_SUCCESS; // NO WOW64! return as executed though it's not true

return ERROR_SUCCESS; // HACK: NO WOW64! return as executed though it's not true

cbialorucki · 2024-05-23T02:29:47Z

dll/win32/msi/custom.c

+ get_binary_type(file->TargetPath, &arch);
+ if (arch == SCS_32BIT_BINARY) {
+ ERR("%s is a 32 bit custom action. Returning as ERROR_SUCCESS\n", debugstr_w(source));
+ return ERROR_SUCCESS; // NO WOW64! return as executed though it's not true


Suggested change

return ERROR_SUCCESS; // NO WOW64! return as executed though it's not true

return ERROR_SUCCESS; // HACK: NO WOW64! return as executed though it's not true

oleg-dubinskiy added the hackfix PRs that look like hacks/workarounds for deeper problems label May 14, 2024

HBelusca reviewed May 14, 2024

View reviewed changes