Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GITHUB] Update Github Actions for Node 16 deprecation preparation #5819

Merged
merged 10 commits into from Feb 9, 2024

Conversation

maj113
Copy link
Contributor

@maj113 maj113 commented Oct 23, 2023

Purpose

Github will start to show deprecation warnings for all Node JS 16 based Github Actions:

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Proposed changes

  • Update Checkout to V4; No major changes, Node version bumped
  • Update Labeler to V4 and remove the now optional repo-token argument, supersedes [GITHUB] Update Labeler action to v4 #5753 (Note that this action is still Node16 based)
  • Update stale action to V8, it has some breaking changes but none seem to be related to our configuration, remove useless issue permission since we don't have issues enabled (Note that it is still node 16 based Stale V9 is Node20 based)

BLOCKERS

@binarymaster binarymaster added the enhancement For PRs with an enhancement/new feature. label Oct 23, 2023
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Oct 23, 2023
@SergeGautherie
Copy link
Contributor

  * [ ]  actions/upload-artifact (feat: bump to use node20 runtime, actions/checkout to v4)

See
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

@SergeGautherie
Copy link
Contributor

SergeGautherie commented Dec 14, 2023

Labeler and Stale seem ready to be updated too.
Note: I would suggest to do these two on a separate PR(s).

@maj113
Copy link
Contributor Author

maj113 commented Jan 9, 2024

I'll get onto this tomorrow, was waiting for the msvc action to get updated

@maj113
Copy link
Contributor Author

maj113 commented Jan 9, 2024

Labeler and Stale seem ready to be updated too. Note: I would suggest to do these two on a separate PR(s).

I'll keep stale here since it requires no significant changes but labeler action needs a config change so I'll split off that one or leave it to #6326, also looks like cache hasn't been updated yet, should I wait or can I update that one separately at a later date?

@maj113 maj113 marked this pull request as ready for review January 10, 2024 19:12
@SergeGautherie
Copy link
Contributor

can I update that one separately at a later date?

Yes.

@maj113 maj113 changed the title [GITHUB] Update Github Actions for Node 16 deprecation preparation WIP [GITHUB] Update Github Actions for Node 16 deprecation preparation Jan 11, 2024
@maj113
Copy link
Contributor Author

maj113 commented Jan 12, 2024

This is ready for review/merge, i'll update cache in a different PR since its taking a while for that to get updated

.github/workflows/labeler.yml Show resolved Hide resolved
ReactOS PRs automation moved this from New PRs to Approved by reviewers Jan 17, 2024
@maj113
Copy link
Contributor Author

maj113 commented Feb 9, 2024

@binarymaster So..... do i close this?

@binarymaster
Copy link
Member

binarymaster commented Feb 9, 2024

Just resolve conflicts (UPD: done).

@github-actions github-actions bot added the drivers Kernel mode drivers and frameworks label Feb 9, 2024
@binarymaster binarymaster removed the drivers Kernel mode drivers and frameworks label Feb 9, 2024
@binarymaster binarymaster merged commit 5974982 into reactos:master Feb 9, 2024
37 checks passed
@maj113 maj113 deleted the Update-Actions branch February 10, 2024 01:18
@binarymaster binarymaster moved this from Approved by reviewers to Done in ReactOS PRs Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For PRs with an enhancement/new feature.
Projects
ReactOS PRs
  
Done
5 participants