Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade parcel to v2 #2385

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jbroma
Copy link
Contributor

@jbroma jbroma commented May 9, 2024

Summary:

builds correctly but no idea if the config is right, needs to be tested

Test Plan:

  • - builds without errors
  • - works as before

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the infra Internal work not facing public APIs label May 9, 2024
@Piotrfj
Copy link

Piotrfj commented May 13, 2024

Tested on debugger-ui, works as intended, there are no additional errors in console.

@jbroma jbroma marked this pull request as ready for review May 13, 2024 14:04
@szymonrybczak
Copy link
Collaborator

szymonrybczak commented May 26, 2024

There's something wrong with specifying exports for browser and node environment, @Piotrfj did you remove previous build?

After running rm -rf build && yarn build, /debugger-ui route fails with an error:

CleanShot 2024-05-26 at 16 27 08@2x

PS. I tried specifying targets and exports field but unfortunately I didn't get it working ;/

@Piotrfj
Copy link

Piotrfj commented May 29, 2024

@szymonrybczak I've done clean install/build on the branch, so I don't think there was any issues with that. @jbroma can you also confirm that the problem issued by @szymonrybczak, I will try to test it soon also

@thymikee
Copy link
Member

thymikee commented Jun 3, 2024

Tested this locally and while building on clear and populated cache works, changing the HTML contents and rebuilding causes SIGSEGV when doing parcel build or just straight not outputting the files to the filesystem (while the Parcel UI states they were built, which I guess is some kind of race condition). Haven't found anything helpful in how to mitigate that other than removing the .parcel-cache folder in project root every time we make a change in HTML.

Provided that we're not going to change this part of the codebase anytime soon (other than deleting it once Experimental Debugger is not experimental anymore), I'm leaning towards merging it as it shouldn't have impact on our users (we publish the build/ folder), just on the contributiors wanting to change stuff there or release the new version that may have some files missing.

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright after @thymikee's investigation and removing .parcel-cache in root directory it seems to work! Thank you @jbroma!

CleanShot 2024-06-03 at 22 27 23@2x

PS. I think it'd be reasonable to add rm -rf .parcel-cache to build-clean script, so whenever someone will be releasing CLI, latest changes will be bundled and published.

@jbroma
Copy link
Contributor Author

jbroma commented Jun 3, 2024

thanks for looking into that @thymikee 🎉

perhaps let's just run the build command with --no-cache instead of deleting it, that should always overwrite the contents

@szymonrybczak
Copy link
Collaborator

Yeah, tested and --no-cache also works for me! Good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Internal work not facing public APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants