-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript 5 #1194
base: master
Are you sure you want to change the base?
Upgrade to TypeScript 5 #1194
Conversation
There is one thing i dont like about |
Otherwise - we're not in hurry here. TS 5 broken lots of things out there, i wast even able to switch any of projects at work, bcause of incompatibility. |
The question I would ask now is: could we get rid of the dependency altogether? Is |
Weeelp, with some tinkering around linting (that will enforce |
And maybe you're right. |
Sounds good. I'm totally up for committing time to this. |
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.0.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
afd996e
to
89aee63
Compare
I upgraded TypeScript, removed |
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 98.49% 98.40% -0.10%
==========================================
Files 62 62
Lines 1064 1064
Branches 179 179
==========================================
- Hits 1048 1047 -1
- Misses 2 3 +1
Partials 14 14
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🤔 does it generate files that have |
Well that was the point of plugin |
The |
Interesting. I guess we'll have to go with |
Nope |
maybe we have to consider finally switch to |
so here's the plan.
|
ts-patch
(the successor ofttypescript
) has released a beta which adds support for TypeScript 5 and asked consumers to test it. In this branch, I've confirmed that this library works with the new version ofts-patch
.I've:
ttypescript
withts-patch
(sincettypescript
is not being developed anymore).useEventListener
that appeared with TypeScript 5.This can be merged later, when the release version of
ts-patch
is available. I'll also format the commit messages then.