Gap filling functionality #1716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yout.. needed to compare the children as well as the layout because somehow the this.props.layout was set without receivingprops
…ty to dynamically turn on/off the fillGaps props
…necessary / don't see why it is there
…ctors to generateGapItem, but the behaviour should be the same
|
This is an awesome addition to the current functionality of RGL and I think we should really look into this as I have a use case for it straight away. |
|
This would be a great addition, and I have a use case for this in mind already. If this needs help (for example with reviewing), I'll gladly dedicate some time after maintainers comment on feasibility. |
|
This is a very needed functionality for RGL. Why is this not merged in yet? |
|
Hey @STRML, this is a very useful feature. What could be done to help with the process of merging it? |
|
I'd be willing to merge this if it were rebased clean and with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any empty spaces in the layout to be filled with a single component. For example, an "add item" button that is always in the empty space and can add a card right where it is located.
Here are some demos - see the example code in the PR:
Screen.Recording.2022-04-25.at.2.29.28.PM.mov
How we use it in our product, DeepSea:
Screen.Recording.2022-04-25.at.2.28.58.PM.mov
My team have actually been using this code in our product for a few years now with no issue, and there are a few reasons I'd really like to see it integrated into react-grid-layout:
This functionality & PR has been built by @drunkplato (Trent Gillham), @presseyt (Tim Pressey) and myself while working at White Whale.
Please let me know if you'd like me to make a corresponding issue - I don't think one is needed but I can make one if it helps track things better!