-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versions/2.0.0 #341
Draft
jeswr
wants to merge
48
commits into
main
Choose a base branch
from
versions/2.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
versions/2.0.0 #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…den in the rdf-star spec
Co-authored-by: Ruben Verborgh <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Note to self for when I revisit in the morning - the matrix based rdf-star tests appear to be passing even on cases they should be failing and erroring. I need to investigate. |
TallTed
reviewed
Mar 24, 2023
* chore: add test cases for named nodes in lists * chore: add more graph in list test cases * fix: correctly handle named graphs in lists
Co-authored-by: Ted Thibodeau Jr <[email protected]>
* fix: support predicates in the list position in Notation3 * chore: remove TODOs
These constructors take the `id` at face value so can be interpreted as the wrong term type if an invalid value is given; for instance a `NamedNode` can be interpred as a `Literal` if instantiated with `new NamedNode('"hellow world"')`. Consumers of the library should use the `DataFactory` instead to create new terms.
Co-authored-by: Tomasz Pluskiewicz <[email protected]>
This was referenced Mar 27, 2023
Before releasing we should make sure that our mime types for rdf-star are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP For version 2 of N3.js
TODO: