Add an environment variable to always build openssl/libssl #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eregon
commented
Nov 9, 2024
eregon
commented
- This is useful when one wants to avoid depending e.g. on which openssl version is installed in Homebrew, notably for libssl.1.1.dylib not found for Ruby 3.0 and TruffleRuby on macos-14 ruby/setup-ruby#668
mislav
reviewed
Nov 11, 2024
bin/ruby-build
Outdated
| @@ -1122,6 +1122,8 @@ normalize_semver() { | |||
| # If a compatible Homebrew-installed OpenSSL version is found during | |||
| # checking, Ruby will be linked to it and the check will return false. | |||
| needs_openssl() { | |||
| [ "$RUBY_BUILD_BUILD_OPENSSL" = "true" ] && return 0 | |||
There was a problem hiding this comment.
- Would a better name be "RUBY_BUILD_VENDOR_OPENSSL" so that it's clear that openssl will be vendored and to avoid saying "build" twice?
- We generally allow any non-blank string to be a truthy value for an environment variable, so I would rewrite this check as:
Suggested change
| [ "$RUBY_BUILD_BUILD_OPENSSL" = "true" ] && return 0 | |
| [ -z "$RUBY_BUILD_VENDOR_OPENSSL" ] || return 0 |
|
For posterity: this adds an opt-out mechanism first requested in #2275 (comment) |
* This is useful when one wants to avoid depending e.g. on which openssl version is installed in Homebrew, notably for ruby/setup-ruby#668
eregon
force-pushed
the
env-var-to-always-build-openssl
branch
from
b83405a
to
3ddd768
Compare
|
I documented it in the README, it should be good to go |
mislav
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.