Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search npm] Hide toast when historyCount is zero #16327

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Jan 12, 2025

Description

  • Hide toast when historyCount is zero
    • This fixes the issue where says items are added to history even when historyCount is zero.
  • Suppress errors when search term is empty
    • The useFetch's onError will always throw a Failed Dependency error even search term is empty
  • Use Raycast's auto-generated type definitions
  • Bump all dependencies to the latest

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: search-npm Issues related to the search-npm extension OP is contributor The OP of the PR is a contributor of the extension labels Jan 12, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @mrmartineau @reloadedhead @TimonVS @luisFilipePT @LunaticMuch @jomifepe @j3lte @ridemountainpig you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 8295d4a into raycast:main Jan 13, 2025
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/mrmartineau/search-npm

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@LitoMore LitoMore deleted the npm/chore-fixes branch January 13, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: search-npm Issues related to the search-npm extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants