Update google-chrome extension #16287
Conversation
- Merge branch \'contributions/merge-1734247600391\' - Pull contributions - Ignore .idea - Add configurable profile path - Initial commit
- fix dep - Merge branch \'contributions/merge-1734247600391\' - Ignore .idea - Add configurable profile path
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @rgomezcasas @bromanko @crisboarna @andreaselia @rtyke @karolre @Aiee @nagauta @a-laughlin @tleo19 @Tarocch1 you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
|
This allows us to configure the Chrome profile path rather than hardcoding it |
|
|
Thanks for submitting a new PR. Taking a look now. |
| const getChromeFilePath = (fileName: string, profile?: string) => { | ||
| const { profilePath } = getPreferenceValues<Preferences>(); | ||
| if (profilePath) { | ||
| return path.join(profilePath, fileName); | ||
| } | ||
| return path.join( | ||
| userLibraryDirectoryPath(), | ||
| ...defaultChromeProfilePath, | ||
| profile ?? DEFAULT_CHROME_PROFILE_ID, | ||
| fileName | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Many bug reports come from an incorrect profile location. Checking whether the file exists here, and explaining what to do if it doesn't, would help prevent those reports.
- Fix conflict - Pull contributions - Improve placeholder
Co-authored-by: Adam Laughlin <[email protected]>
- Fix merge - Pull contributions - Fix linting again
|
Great! Looks good to merge once reviewed by Raycast folks. cc @pernielsentikaer Side note I got curious and looked at what happens to the new error message once it's thrown. It appears to be ignored (useBookmarksSearch) and unhandled (useHistorySearch). Error handling is inconsistent and could use some cleanup. To avoid blocking this PR, I created a separate issue for updating error handling in useHistorySearch and useBookmarksSearch. Merging this without improving the error handling will still improve the errors. In the bookmarks case, the error will be as unhelpful as it currently is. In the unhandled |
|
yeah @a-laughlin I guess we can have a new erroView for it, great call and thanks for the patience reviewing the PR |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder