Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate-send-webpage-to-reader extension #16108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajason
Copy link

@ajason ajason commented Jan 2, 2025

Description

Screencast

Checklist

- 1
- docs: README update, add icon, translate to english.
- chore: 添加调试日志以便于内容处理和 HTML 生成
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 2, 2025

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jan 2, 2025
@ajason
Copy link
Author

ajason commented Jan 2, 2025

I accidentally created a new PR. Please refer to the history of the old PR at #15928.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing 🙂

Comment on lines 5 to 10
interface Preferences {
readwiseToken: string;
autoTranslate: boolean;
targetLanguage: string;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interface Preferences {
readwiseToken: string;
autoTranslate: boolean;
targetLanguage: string;
}

You don't need to manually set preference types as this is autogenerated in raycast-env.d.tsx

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have removed the preference types.

@pernielsentikaer pernielsentikaer self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants