[ci] skip the failing cpp tests on mac #45273
Conversation
Signed-off-by: can <[email protected]>
| ray cpp --generate-bazel-project-template-to ray-template | ||
| pushd ray-template && bash run.sh |
There was a problem hiding this comment.
shouldn't we fix this rather than skipping?
maybe have two tests one with this, one without or something? so that the failure is separated rather than just skipped?
There was a problem hiding this comment.
let's create a ticket to fix it yes, my proposal is to stop running it on CI until that is fixed
There was a problem hiding this comment.
split into another job is also fine yes, but it burns money by keeping failing and retrying itself
There was a problem hiding this comment.
burns money by keeping failing and retrying itself
they just exit 1 here. I am okay with skipping running tests, but I prefer to have a red color if it should be release blocking.
There was a problem hiding this comment.
red color if it should be release blocking
This is the problem yeah; the whole jobs are currently soft-failed and completely ignored (I removed the failing part and also removed the soft fail in this PR).
|
we probably need @jjyao to see if we can track this test separately and not through a soft fail job in CI |
|
discussed offline, Jiajun will help to cut tickets for ant to follow up; we'll skip it in CI until it's fixed |
Skip the current failing cpp tests on mac so that it can pass. It currently soft-fails, hinders other errors, etc. Test: - https://buildkite.com/ray-project/premerge/builds/25983#018f69fc-44dc-4329-b5af-0dcfdd59d74b Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
Skip the current failing cpp tests on mac so that it can pass. It currently soft-fails, hinders other errors, etc. Test: - https://buildkite.com/ray-project/premerge/builds/25983#018f69fc-44dc-4329-b5af-0dcfdd59d74b Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
Skip the current failing cpp tests on mac so that it can pass. It currently soft-fails, hinders other errors, etc.
Test: