Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Improve logging during accelerator auto-detection #45240

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HenryZJY
Copy link

@HenryZJY HenryZJY commented May 10, 2024

Why are these changes needed?

This PR improves the user experience during accelerator auto-detection. Currently errors from accelerator autodetection are suppressed. With the changes in this PR, if a user specifies accelerator(s) as part of available resources (for example, ray.init(num_gpus=3)), and that resource encounters errors during auto-detection, an error message will be logged.

I also added an additional check in resource_spec.py which adds an entry to logger if raylet wants a certain number of accelerators but visible accelerator id is None.

Related issue number

Closes #43328

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@HenryZJY HenryZJY changed the title Improve logging during accelerator auto-detection [Core] Improve logging during accelerator auto-detection May 11, 2024
Signed-off-by: Henry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Improve UX if accelerator autodetection fails unexpectedly
1 participant