[Core] Improve logging during accelerator auto-detection #45240
+89
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR improves the user experience during accelerator auto-detection. Currently errors from accelerator autodetection are suppressed. With the changes in this PR, if a user specifies accelerator(s) as part of available resources (for example,
ray.init(num_gpus=3)
), and that resource encounters errors during auto-detection, an error message will be logged.I also added an additional check in
resource_spec.py
which adds an entry to logger if raylet wants a certain number of accelerators but visible accelerator id isNone
.Related issue number
Closes #43328
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.