[dashboard] Removes ray.rpc.ReportEventService and Dashboard head as gRPC server. #45219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at all. Signed-off-by: Ruiyang Wang <[email protected]>
rynewang
requested review from
ericl,
richardliaw,
rkooo567 and
jjyao
as code owners
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
aslonnie
reviewed
May 9, 2024
| @@ -149,7 +149,6 @@ In addition to ports specified above, the head node needs to open several more p | |||
| - ``--port``: Port of Ray (GCS server). The head node will start a GCS server listening on this port. Default: 6379. | |||
| - ``--ray-client-server-port``: Listening port for Ray Client Server. Default: 10001. | |||
| - ``--redis-shard-ports``: Comma-separated list of ports for non-primary Redis shards. Default: Random values. | |||
There was a problem hiding this comment.
so this change is not backward compatible?
There was a problem hiding this comment.
We still accept this arg, just no longer use it, so existing workload won't crash (will receive a warning)
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
May 13, 2024
| serialized_proto = request.SerializeToString() | ||
| with aiohttp.ClientSession() as session: | ||
| async with session.post( | ||
| f"http://{self._dashboard_address}/report_events", |
There was a problem hiding this comment.
Suggested change
| f"http://{self._dashboard_address}/report_events", | |
| f"http://{self._dashboard_address}/events", |
?
jjyao
reviewed
May 13, 2024
Comment on lines
677
to
+681
| def dashboard_grpc_port(self): | ||
| """Get the dashboard head grpc port""" | ||
| return self._dashboard_grpc_port | ||
| raise AttributeError( | ||
| "Dashboard grpc server is removed. There is no port to " "listen." | ||
| ) |
There was a problem hiding this comment.
Is this used? If not, we can completely remove it?
There was a problem hiding this comment.
Not used. I kept it for backward compatibility. I can remove it if you like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dashboard Head is an HTTP server as well as a gRPC server. The latter only serves 1 single gRPC service: ray.rpc.ReportEventService and its only method's only usage is from the Dashboard Agent in event_agent.py. This PR replaces the RPC with HTTP and removes the Head's ability to serve as a gRPC server. Note, it still has gRPC clients sending RPCs to Agents, Raylets and GCS.
This is a step forward to remove all gRPC usage from the head.