-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation branch #176
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a very high level, please ensure the linter are passing, write unit tests for each class and document the testing steps in the description of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think implementation still requires some cosmetic and logical fixes.
deltacat/utils/ray_utils/retry_handler/AIMD_based_batch_scaling_strategy.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/AIMD_based_batch_scaling_strategy.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/AIMD_based_batch_scaling_strategy.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/AIMD_based_batch_scaling_strategy.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/AIMD_based_batch_scaling_strategy.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/ray_task_submission_handler.py
Outdated
Show resolved
Hide resolved
deltacat/utils/ray_utils/retry_handler/ray_task_submission_handler.py
Outdated
Show resolved
Hide resolved
The tests are failing. Please check. |
This PR handles the implementation of a few aspects of the RetryHandlerSkeleton. Specifically, Additive Increase Multiplicative Decrease Batch scaling along with the basic case of executing retries on a detected Retry-able Exception.
There are two test suites in this PR: