Fixed compilation error under gcc10 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the patch, this is the error message with GCC 10.2.0:
CXX playbackprefs.o
In file included from vrender.h:25,
from playbackengine.C:41:
commonrender.h: In member function 'virtual int CommonRender::stop_rendering()':
commonrender.h:96:32: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
96 | int virtual stop_rendering() {};
| ^
commonrender.h: In member function 'virtual int CommonRender::wait_device_completion()':
commonrender.h:98:40: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
98 | virtual int wait_device_completion() {};
| ^
commonrender.h: In member function 'virtual int CommonRender::process_buffer(int64_t, int64_t)':
commonrender.h:100:73: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
100 | virtual int process_buffer(int64_t input_len, int64_t input_position) {};
| ^
commonrender.h: In member function 'virtual int CommonRender::get_datatype()':
commonrender.h:102:30: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
102 | virtual int get_datatype() {};
| ^
commonrender.h: In member function 'virtual int64_t CommonRender::get_render_length(int64_t)':
commonrender.h:113:68: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
113 | virtual int64_t get_render_length(int64_t current_render_length) {};
| ^
In file included from mwindow.h:81,
from playbackengine.C:30:
playbackengine.C: In member function 'void PlaybackEngine::perform_change()':
transportque.inc:50:31: error: narrowing conversion of '4294967295' from 'unsigned int' to 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wnarrowing-Wnarrowing8;;]
50 | #define CHANGE_ALL 0xffffffff
| ^~~~~~~~~~
playbackengine.C:180:8: note: in expansion of macro 'CHANGE_ALL'
180 | case CHANGE_ALL:
| ^~~~~~~~~~
make[3]: *** [Makefile:1761: playbackengine.o] Error 1
make[3]: *** Waiting for unfinished jobs....
playbackprefs.C: In member function 'int PlaybackPrefs::get_buffer_bytes()':
playbackprefs.C:260:1: warning: no return statement in function returning non-void [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type-Wreturn-type8;;]
260 | }
| ^
make[3]: Leaving directory '/build/source/cinelerra'
make[2]: *** [Makefile:1792: all-recursive] Error 1
make[2]: Leaving directory '/build/source/cinelerra'
make[1]: *** [Makefile:522: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:452: all] Error 2
iblech
force-pushed
the
patch-narrowing
branch
from
a1b2d9c
to
71fb053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I'm not actually an user of CinelerraCV; I just noticed that the Nix build is failing. This patch fixes the compilation error, and I believe that the new version is what has been actually intended all along. With the patch, CinelerraCV compiles just fine and starts nicely. But I cannot judge whether it works as it should.
Thank you for your working maintaining CinelerraCV :-)