Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-121 - Added missing property for PHP 8.2 compatibility #32

Merged

Conversation

FatchipRobert
Copy link
Contributor

The requestModel property is used in the class but was not declared as a property.

This is deprecated in PHP 8.2

This fixes the problem.

@hamail-tahir
Copy link
Contributor

Please fix the failing checks.

  1. php-library/src/RequestBuilder.php (no_trailing_whitespace_in_comment)

@hamail-tahir
Copy link
Contributor

Can you please change the "donatj/mock-webserver" package to version "<=2.5.0" in composer.json to see if the checks pass.

@hamail-tahir hamail-tahir merged commit 4fc20f9 into ratepay:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants