fix: make event loop handle send errors correctly #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the crossterm event stream is dropped, or the application event channel is dropped, the event loop now correctly exits. If the init event fails to send, the application will likely not work correctly, so the event loop now panics if the init event fails to send. Refactored the event loop to make it easier to read and understand.
kdheepak
reviewed
Jul 14, 2024
kdheepak
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the crossterm event stream is dropped, or the application event
channel is dropped, the event loop now correctly exits.
If the init event fails to send, the application will likely not work
correctly, so the event loop now panics if the init event fails to send.
Refactored the event loop to make it easier to read and understand.