This repository has been archived by the owner on Dec 10, 2019. It is now read-only.
Add method to post annotations for project #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I was in the habit of adding a method for each RV script, but it's too much work to keep these up to date, and they aren't very useful. The only method we need is one that corresponds to making predictions.
If we can create project config files which represent a set of projects and their associated files, then I can train and eval models using RV without needing anything further from this Python client, which simplifies things.
lewfish
force-pushed
the
feature/lf/post-predictions
branch
from
3170c3e to
9597250
Compare
|
Note: I need to make a release containing this PR. |
Lknechtli
reviewed
Jan 25, 2018
rasterfoundry/spec.yml
Outdated
| x-top-matter: | ||
| - title: Introduction | ||
| level: 1 | ||
| content: | | ||
| The Raster Foundry API allows developers to find, view, and analyze geospatial data in Raster Foundry. As the name implies, it's especially useful for working with large raster datasets like satellite imagery. | ||
| content: > |
There was a problem hiding this comment.
pretty sure this will break things in the spec - the swagger.io editor defaults to swagger 3.0, and we're using 2.0.
There was a problem hiding this comment.
Fixed it. I'll use the 2.0 Editor for now on.
This also has the Polygon definition added which should be added to the spec.yml in the RF repo. I have a note in an issue to do this.
lewfish
force-pushed
the
feature/lf/post-predictions
branch
from
9597250 to
b9c4d84
Compare
|
Can we try to get this reviewed soon? It's blocking me on https://github.com/azavea/raster-foundry-deployment/pull/115 |
Lknechtli
approved these changes
Jan 26, 2018
| @@ -1,4 +1,4 @@ | |||
| RV_CPU_QUEUE = 'raster-vision-cpu' | |||
| RV_CPU_JOB_DEF = 'raster-vision-cpu' | |||
| RV_PROJ_CONFIG_DIR_URI = 's3://raster-vision-od/configs/projects' | |||
| RV_PROJ_CONFIG_DIR_URI = 's3://raster-vision-lf-dev/detection/configs/projects/rf-generated' | |||
There was a problem hiding this comment.
shouldn't these kinds of settings be stored in a gitignored file with an example placeholder file committed? We do something similar in RF
There was a problem hiding this comment.
Good point. I have too much other stuff do right now, so I made an issue to do that: #43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to posts annotations for a project that are stored in a JSON file on S3. This will be called by the Lambda function in https://github.com/azavea/raster-foundry-deployment/pull/115. This also makes some other changes to stay in sync with the latest RV and removes some methods which are not useful and annoying to maintain.
To test making a prediction, run the following commands:
To test posting predictions, run the following after clearing the annotations in the UI at https://app.rasterfoundry.com/projects/edit/de3780a1-9f3e-4fa3-a811-ad3060b64866/annotate
Connect #41