Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtoverlays: Use continuous clock mode for ov9281 #6542

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented Dec 16, 2024

This increases the maximum frame rate from 247 to 260fps in 10-bit mode.

This increases the maximum frame rate from 247 to 260fps in
10-bit mode.

Signed-off-by: Dave Stevenson <[email protected]>
@pelwell
Copy link
Contributor

pelwell commented Dec 16, 2024

Can you explain briefly why this change can't be applied to all cameras, and why it mostly (but not always) must be applied to both ends?

@6by9
Copy link
Contributor Author

6by9 commented Dec 17, 2024

Support of continuous vs non-continuous mode is down to the sensor driver and whether it checks DT for the setting and acts accordingly. Many drivers don't check and assume it is correct.
The CSI2 receiver driver generally needs to know in order to avoid looking for the LP->HS transition on the clock lane and therefore not syncing.

Why V4L2 doesn't pass the setting from source to sink is their policy decision, and you're not meant to go rummaging in other DT entities to extract it yourself. There is actually an API call that does allow passing the setting, but it's not widely implemented, and whenever anyone has implemented it just to relay this clock mode information, it has been rejected. (DRM does do the sensible thing and passes it from panel/bridge driver to the DSI host controller).

Not dropping to LP mode on the clock lane saves a little time per line, hence this sensor driver allows the blanking period to be reduced slightly to match. AFAIK that is unique to OV928[12] as I noticed it and fixed it up (torvalds/linux@a387834)

@pelwell
Copy link
Contributor

pelwell commented Dec 17, 2024

Thanks - that makes sense.

@pelwell pelwell merged commit a4a4d7f into raspberrypi:rpi-6.6.y Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants