This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Task to manage chefignore file #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim of this change is to try to detect the presence of the ignore files/directores in the `chefignore` file and try to add them if they are missing. In addition to adding the ignore files to the `chefignore` file we are displaying a warning to the user suggesting they update their `chefignore` file in the source repo so we don't have to do this. Finally, we copy the `chefignore` file to the `.builderator` so that the `berks` binary can find and use it. The content we are adding looks like this: ``` .builderator ``` We are no longer nesting vendored cookbooks, so this fixes #88. ``` $ find .builderator -name rapid7-logstash-server $ find .builderator/cookbooks | wc -l 813 ```
|
Looks good! 👍 |
erran-r7
reviewed
Oct 26, 2016
| @@ -23,6 +23,26 @@ def configure | |||
| Interface.berkshelf.write | |||
| end | |||
|
|
|||
| desc 'chefignore', 'Create or Update chefignore to ignore .builderator directory' | |||
| def chefignore | |||
| ignore_file_list = ['.builderator'] | |||
There was a problem hiding this comment.
@athompson-r7 how about making this a method_option (--ignore-files) and defaulting to [".builderator"]?
| ignore_file = ::File.readlines(ignore) | ||
| ignore_file.map! { |i| i.chomp } | ||
| files = ignore_file_list.all? { |i| ignore_file.include?(i) } | ||
| unless files |
There was a problem hiding this comment.
How about unless all_files_ignored instead?
erran-r7
approved these changes
Oct 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this change is to try to detect the presence of the ignore
files/directores in the
chefignorefile and try to add them if theyare missing.
In addition to adding the ignore files to the
chefignorefile we aredisplaying a warning to the user suggesting they update their
chefignorefile in the source repo so we don't have to do this.Finally, we copy the
chefignorefile to the.builderatorso that theberksbinary can find and use it.The content we are adding looks like this:
We are no longer nesting vendored cookbooks, so this fixes #88.