Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Fix Partial Path Traversal Vulnerability #1322

Closed
wants to merge 1 commit into from
Closed

[SECURITY] Fix Partial Path Traversal Vulnerability #1322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion byte-buddy-dep/src/main/java/net/bytebuddy/build/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3397,7 +3397,7 @@ public void retain(Source.Element element) throws IOException {
String name = element.getName();
if (!name.endsWith("/")) {
File target = new File(folder, name), resolved = element.resolveAs(File.class);
if (!target.getCanonicalPath().startsWith(folder.getCanonicalPath())) {
if (!target.getCanonicalFile().toPath().startsWith(folder.getCanonicalFile().toPath())) {
throw new IllegalArgumentException(target + " is not a subdirectory of " + folder);
} else if (!target.getParentFile().isDirectory() && !target.getParentFile().mkdirs()) {
throw new IOException("Could not create directory: " + target.getParent());
Expand Down