[v2.9] Remove PSP checks from SUC charts and it's upgrade process #45427
+10
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiukapoor
force-pushed
the
psp-remove-k3s-rke2
branch
2 times, most recently
from
5c47d13
to
cff38bd
Compare
Signed-off-by: Chirayu Kapoor <[email protected]>
chiukapoor
force-pushed
the
psp-remove-k3s-rke2
branch
from
cff38bd
to
eae2d9a
Compare
Sahota1225
requested review from
a team and
kinarashah
and removed request for
a team
kinarashah
reviewed
Jun 5, 2024
| @@ -179,10 +178,12 @@ func (h *handler) deployK3sBasedUpgradeController(clusterName, updateVersion str | |||
| } | |||
| } | |||
|
|
|||
| desiredApp := app.DeepCopy() | |||
| if desiredApp.Spec.Answers == nil { | |||
There was a problem hiding this comment.
@chiukapoor Why are we removing Answers field check here? I first thought it's cuz it won't be nil as we initialized map in app spec but looks like we removed it there too.
There was a problem hiding this comment.
Context of this removal is lost after rebasing with the latest changes pushed by 1.29 PR where some extent of PSP removal was done. This commit from the 1.29 PR is the other part of this PR.
The Answers field was only being used to cater the PSPAnswersField in it. Now as the PSPAnswersField is removed we may safely remove the Answers field as well.
We are kind of reverting #40445 PR which add PSP checks and Answers field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Problem
TODO
Solution
Engineering Testing
Manual Testing
v2.8.3. Deployed rke2 1.28 k8s downstream cluster.values.yamlof SUC chart.