Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better browser performance + fixed settings panel + pulled upstream plugin template (upgraded gradle and build tools) #193

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

ramonvermeulen
Copy link
Owner

@ramonvermeulen ramonvermeulen commented Oct 19, 2024

  • upgraded all the intellij idea plugin template related files based on the upstream repository, big changes in gradle set-up, and minor changes in CI/CD pipelines
  • disabled offscreen rendering for the embedded lineage panel browser which increased performance
  • fixed the settingsPanel (which had some bugs while trying to apply changed settings)
  • moved addBrowseFolderListener to another function signature which is not deprecated, solves TextFieldWithBrowseButton.addBrowseFolderListener is deprecated in future IDE release #187
  • implemented Disposable in (I think) the correct way, tried to stick with the IDEA plugin documentation about this concept
  • upgraded new minor due to a lot of changes (should've actually already done this with v0.1.2 my bad)

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 42.64706% with 39 lines in your changes missing coverage. Please review.

Project coverage is 16.84%. Comparing base (f652512) to head (84b631a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...amonvermeulen/dbtToolkit/ui/panels/LineagePanel.kt 0.00% 9 Missing ⚠️
...vermeulen/dbtToolkit/ui/panels/CompiledSqlPanel.kt 0.00% 6 Missing ⚠️
...vermeulen/dbtToolkit/ui/panels/PreviewDataPanel.kt 0.00% 6 Missing ⚠️
...lkit/ui/settings/DbtToolkitSettingsConfigurable.kt 83.87% 2 Missing and 3 partials ⚠️
...onvermeulen/dbtToolkit/services/ManifestService.kt 0.00% 4 Missing ⚠️
...rmeulen/dbtToolkit/ui/panels/ConsoleOutputPanel.kt 0.00% 4 Missing ⚠️
...b/ramonvermeulen/dbtToolkit/ui/panels/DocsPanel.kt 0.00% 4 Missing ⚠️
...dbtToolkit/services/ProcessOutputHandlerService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   16.92%   16.84%   -0.09%     
==========================================
  Files          28       28              
  Lines         827      843      +16     
  Branches      110      110              
==========================================
+ Hits          140      142       +2     
- Misses        679      694      +15     
+ Partials        8        7       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@ramonvermeulen ramonvermeulen changed the title T.b.d. fix: better browser performance + fixed settings panel + pulled upstream plugin template (upgraded gradle and build tools) Oct 19, 2024
@ramonvermeulen ramonvermeulen merged commit 368dc12 into main Oct 19, 2024
8 checks passed
@ramonvermeulen ramonvermeulen deleted the ramon/new-browser branch October 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant