Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1033. Proper title tag #1039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muhammed-ajmal
Copy link
Member

@muhammed-ajmal muhammed-ajmal commented Aug 10, 2019

Issue Reference

This PR addresses the Issue : Fixes #1033

Changes

I had updated the base.html template with {% block title %}{% endblock %}
then extended it all other templates( html files)

Unfortunately, you can see there are many deletions of blank spaces, these changes are done by atom editor itself.

@muhammed-ajmal
Copy link
Member Author

muhammed-ajmal commented Aug 10, 2019

Do we need to add Malayalam version ?, I found google -translator already translating titles to Malayalam

@sreenadh
Copy link

Duplicate code

<title>{% block title %}{% endblock %}Kerala Rescue</title>

Change to

<title>{% block title %}{% endblock %} - Kerala Rescue</title>

And for individual pages, for eg
Change
{% block title %}Announcements&nbsp-&nbsp{% endblock %}

To

{% block title %}Announcements{% endblock %}

@sreenadh
Copy link

@ajuajmal its better to pass title from controller so that we can use it directly in base.html for both breadcrumb's last tag and <title> tag and add parents only in individual views. Or define a breadcrumb class to define breadcrumbs in a centralized location and simply call the method in respective views along with title.

@subins2000
Copy link

@ajuajmal can you please fix the conflicts ?

Also, my PR #1054 adds a permalink to announcements. Can the page have a meta description and proper title so that the announcement can be shared via whatsapp/social media with proper previews ? This'll solve #1057

Copy link
Member

@dauntlessnomad dauntlessnomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix merge conflicts

@sreenadh
Copy link

@ajuajmal please fix the merge conflicts.

@biswaz biswaz changed the title proper-<title>-tag-#1033 Fix 1033. Proper title tag Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate title tags wrt page
7 participants