Multiple quality improvements - squid:S00117, squid:S00116 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure whether you do not agree with these changes or not. Please close this PR if not. |
| @@ -79,15 +79,14 @@ public UserMailboxHttpService(ApiKeyService apiKeyService, UserPluginConfig conf | |||
| public void listenMails(RakamHttpRequest request) { | |||
| RakamHttpRequest.StreamResponse response = request.streamResponse(); | |||
|
|
|||
| List<String> apiKey = request.params().get("api_key"); | |||
There was a problem hiding this comment.
you can't basically change string values, it will break the api.
|
Oh, yep, this may be happened after fixing the conflicts |
|
You also make some fields static. I think it's hard to guess which variables should be static with automation tools because some of the fields are instance fields because of thread-safety issues. I would rather to keep them as they are. |
|
Ok, reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules squid:S00117 - Local variable and method parameter names should comply with a naming convention
squid:S00116 - Field names should comply with a naming convention
You can find more information about the issues here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S00117
https://dev.eclipse.org/sonar/coding_rules#q=squid:S00116
Please let me know if you have any questions.
M-Ezzat