Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosschainswaps V3 #71

Merged
merged 14 commits into from May 2, 2024
Merged

Conversation

fringlesinthestreet
Copy link
Contributor

@fringlesinthestreet fringlesinthestreet commented Apr 26, 2024

As relay's dest address is an EOA, just forcing the to address as we used to do with socket will result in the tx going through (and possibly losing funds if it was edited), so now it throws an error instead.

sdk/package.json Outdated Show resolved Hide resolved
@fringlesinthestreet
Copy link
Contributor Author

Needs:

  • publish new swap SDK version on npm
  • Update versions on APP & BX
  • A changes on frontend logic to avoid generating an unnecessary approval tx

APP

Need to replace this line with:

  const shouldNotHaveApproval = tradeDetails.no_approval !== undefined && tradeDetails.no_approval;
  if (!nativeAsset && routeAllowanceTargetAddress && !shouldNotHaveApproval) {

BX

Need to replace this line with:

  const shouldNotUnlockAsset = quote.no_approval !== undefined && quote.no_approval;
  if (!isNativeAssetUnwrapping && !nativeAsset && !shouldNotUnlockAsset) {

sdk/src/utils/sanity_check.ts Outdated Show resolved Hide resolved
sdk/src/utils/sanity_check.ts Show resolved Hide resolved
@fringlesinthestreet fringlesinthestreet merged commit a1071ec into main May 2, 2024
1 check passed
@fringlesinthestreet fringlesinthestreet deleted the @benjamin/add_relay_link_support branch May 2, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants