Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues/64: Graph doesn't appear if all the "y" values are equal, but "x" values are different #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dynamichny
Copy link
Contributor

Problem:
Chart was appearing above the "canvas", because both extremes were exactly the same.

Solution:
Setting extremes to values between Y (so 1 and -1 for value 0) solves the problem.

Issue:
#64

simulator_screenshot_FFC82071-CB30-42B9-84B8-E9411BFD9FE9

@dynamichny
Copy link
Contributor Author

@osdnk Could you take a look? :)

@SophieJung7
Copy link

SophieJung7 commented Jan 4, 2022

@dynamichny I just tested your code and the graph works fine as you attached. But this code has a bug. Since it edits the original data of greatestY and smallestY, if someone uses greatestY and smallestY value from useChartData, the value is incorrect. Should purposely greatestY - 1 and smallestY + 1 from the useChartData.
Screenshot 2022-01-04 at 17 28 49
For example, I use greatestY and smallestY value from useChartData(), but the value as you can see is incorrect.

@dynamichny
Copy link
Contributor Author

@SophieJung7 Good point, so I guess I'd need to check if value is the same somewhere deeper, I'll check it later today

@SophieJung7
Copy link

Thnx a lot, @dynamichny ! Now it is working perfectly!:)

@andreibahachenka
Copy link

guys, how much does it take usually to merge a request?

@dynamichny
Copy link
Contributor Author

@b0n1q it may take some time, there are already 4 PR's waiting for approval, if you need to have it fixed in your project, you can try to fix it locally and patch it using patch-package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants