refactor: wallets #1869
refactor: wallets #1869
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| id, | ||
| name, | ||
| provider, |
There was a problem hiding this comment.
Those return types are required in wagmi. Reference to the docs here.
| id: 'rainbow', | ||
| name: 'Rainbow', | ||
| flag: 'isRainbow', | ||
| }), |
There was a problem hiding this comment.
What are id and name used for here? Is there a way for us to prevent needing to implement id and name twice within the wallet connector?
There was a problem hiding this comment.
Because we call createConnector, shouldn't we be able to pass in id at connect time?
There was a problem hiding this comment.
Mhmm good point. We could, but then we would have to do something similar to what we do with mockWallet here which would add more logic on top. When doing createConnector we're creating a brand new connector, but don't append the id's to our created connectors like injected(), walletConnect(), safe() and etc (since they are in a created mode).
We could maybe generate random uuid's, but not sure if that would cause problems.
| @@ -44,6 +44,8 @@ export const ramperWallet = (): Wallet => { | |||
| }, | |||
| }, | |||
| createConnector: getInjectedConnector({ | |||
| id: 'ramper', | |||
| name: 'Ramper Wallet', | |||
| namespace: 'ramper2.provider', | |||
There was a problem hiding this comment.
Likewise, should we be moving namespace to the top-level wallet connector, instead of implementing it here? getInjectedConnector was previously a bit more of a simple util, and the added complexity might require a more in-depth refactor
There was a problem hiding this comment.
I think we need to refactor much of the code in the walletListItems for loop, as the spread operators and var naming is getting tough to understand. Need comments here too. Rewinding back to v1, it was a bit easier to read and had comments: https://github.com/rainbow-me/rainbowkit/blob/42b0661e622ba99ec98cdb0219431f90ca45d40d/packages/rainbowkit/src/wallets/connectorsForWallets.ts
…d introduce new util functions
Changes
What to test