Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1434] feat: add keyboard navigation to the points dashboard #1522

Merged
merged 3 commits into from Apr 30, 2024

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Keyboard navigation added to the points dashboard and the weekly earnings modal

Screen recordings / screenshots

https://www.loom.com/share/41a8d23a3c0a4827937a62d5f528906e

What to test

Traverse the points screen with the keyboard. Cards with onClick/onTap handlers should work when pressing ENTER.

Copy link

linear bot commented Apr 26, 2024

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6d489bd68b239e68870ddf2daed5943682fc2c95.zip

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6d489bd68b239e68870ddf2daed5943682fc2c95.zip

Copy link

Here's the packed extension for this build:
rainbowbx-a37a687af3f0d32eb2ceb8dd4eaa3f5f956c3146.zip

@derHowie derHowie added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
Copy link

Here's the packed extension for this build:
rainbowbx-1ec1c810cbdc46c2bf44fe1329b74096af02db2a.zip

@derHowie derHowie added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@derHowie derHowie added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit a91e1c9 Apr 30, 2024
17 checks passed
@derHowie derHowie deleted the @chris/points-kb-nav branch April 30, 2024 10:00
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a91e1c95dd21c720ff43c981af6690c4ea01c7cf.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants