Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1431] ESC to dismiss Token Details fails #1521

Merged
merged 6 commits into from May 11, 2024

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Added a few tweaks to the token details page to ensure that ESC behaves correctly

What to test

Make sure you can close the token details modal without closing the popup.

Copy link

linear bot commented Apr 26, 2024

Copy link

Here's the packed extension for this build:
rainbowbx-40854edeac060fa6b7a79e9e806ed82407924697.zip

setTimeout(() => {
app?.focus();
}, 150);
}, []);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this was as last resource?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. This issue exists throughout the app, but I placed a hook inside AnimatedRoute to handle it.

This screen is not using animated route, so I had to put it in manually.

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9d5894ee95b55dc0faa018297ad0837be1171a72

Copy link

github-actions bot commented May 2, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9d5894ee95b55dc0faa018297ad0837be1171a72

Copy link

github-actions bot commented May 2, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9d5894ee95b55dc0faa018297ad0837be1171a72

Copy link

github-actions bot commented May 3, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9d5894ee95b55dc0faa018297ad0837be1171a72

Copy link

github-actions bot commented May 8, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-99a408664a08c0a5d859223ba2a75093231e510a

Copy link

Here's the packed extension for this build:
rainbowbx-c455d24edcadb939baf0e2aba28d950ad1afc128

@DanielSinclair DanielSinclair added this pull request to the merge queue May 11, 2024
Merged via the queue into master with commit fc32698 May 11, 2024
15 checks passed
@DanielSinclair DanielSinclair deleted the @chris/back-from-token-details branch May 11, 2024 23:00
Copy link

Here's the packed extension for this build:
rainbowbx-fc32698c7485f2e98415670458ed10d71754d0e6

DanielSinclair added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants