Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox release workflow fixes, readme #1515

Merged
merged 7 commits into from Apr 30, 2024
Merged

Conversation

DanielSinclair
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

  • Removed duplicate yarn firefox:manifest call that tweaks the binary output
  • Added readme with Firefox build steps
  • Removed .zip in artifact naming to prevent .zip.zip
  • Removed unused commit version bump step in production release workflow
  • Resolved firefox release errors by commenting out unused release steps

Screen recordings / screenshots

What to test

@DanielSinclair DanielSinclair changed the title firefox release fixes, readme firefox release workflow fixes, readme Apr 24, 2024
@DanielSinclair DanielSinclair requested review from a team and BrodyHughes April 24, 2024 07:53
@DanielSinclair
Copy link
Contributor Author

@BrodyHughes Few changes for quality of life for our Firefox release process

Copy link

Here's the packed extension for this build:
rainbowbx-66533933e996c080fb6870de7ea9a508b4a57178

@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a3c67f8932cc93dbfe80675fc93894b500b7f448

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a3c67f8932cc93dbfe80675fc93894b500b7f448

@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 30, 2024
Copy link

Here's the packed extension for this build:
rainbowbx-80e09578689004aee06bc4d1d46b8d42fc6229fc

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 8f1e232 Apr 30, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/firefox-readme branch April 30, 2024 19:36
Copy link

Here's the packed extension for this build:
rainbowbx-8f1e2329756ce41be721a36900f66cc853d2b8cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants