Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup e2e names, refactor op script for more networks #1514

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 22 additions & 22 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ jobs:
- name: Fail if any tests failed
if: steps.FFE2eSend.outcome == 'failure'
run: exit 1
firefox-e2e-dappInteractions:
runs-on: dapp-interactions-runner-bx
firefox-e2e-dapp:
runs-on: dapp-runner-bx
timeout-minutes: 25
needs: [build]
env:
Expand All @@ -172,23 +172,23 @@ jobs:
- uses: ./.github/actions/firefoxTestsSetup
with:
gh-access-token: ${{ secrets.DOTENV_GITHUB_ACCESS_TOKEN }}
- name: Run e2e Dapp Interactions (Firefox)
id: FFE2eDappInteractions
- name: Run e2e Dapp (Firefox)
id: FFE2eDapp
continue-on-error: true
run: |
export BROWSER=firefox
export OS=linux
export FIREFOX_BIN="$(pwd)/firefox/firefox"
yarn firefox:manifest && yarn firefox:zip
yarn vitest:dappInteractions
yarn vitest:dapp
- name: Upload deps artifacts
if: steps.FFE2eDappInteractions.outcome == 'failure'
if: steps.FFE2eDapp.outcome == 'failure'
uses: actions/upload-artifact@v3
with:
name: screenshots
path: screenshots/
- name: Fail if any tests failed
if: steps.FFE2eDappInteractions.outcome == 'failure'
if: steps.FFE2eDapp.outcome == 'failure'
run: exit 1
# CHROME TESTS
chrome-e2e-parallel:
Expand Down Expand Up @@ -278,8 +278,8 @@ jobs:
- name: Fail if any tests failed
if: steps.ChromeE2ESend.outcome == 'failure'
run: exit 1
chrome-optimism-e2e-send:
runs-on: send-runner-bx
chrome-e2e-networks:
runs-on: networks-runner-bx
timeout-minutes: 25
needs: [build]
env:
Expand All @@ -290,25 +290,25 @@ jobs:
- uses: ./.github/actions/chromeTestsSetup
with:
gh-access-token: ${{ secrets.DOTENV_GITHUB_ACCESS_TOKEN }}
- name: Run Optimism e2e send (Chrome)
id: ChromeOpE2ESend
- name: Run Netoworks e2e (Chrome)
id: ChromeE2ENetworks
continue-on-error: true
run: |
export BROWSER=chrome
export OS=linux
export CHROMIUM_BIN=$(find chrome -type f -name 'chrome')
yarn vitest:send:optimism
yarn vitest:networks
- name: Upload deps artifacts
if: steps.ChromeOpE2ESend.outcome == 'failure'
if: steps.ChromeE2ENetworks.outcome == 'failure'
uses: actions/upload-artifact@v3
with:
name: screenshots
path: screenshots/
- name: Fail if any tests failed
if: steps.ChromeOpE2ESend.outcome == 'failure'
if: steps.ChromeE2ENetworks.outcome == 'failure'
run: exit 1
chrome-e2e-dappInteractions:
runs-on: dapp-interactions-runner-bx
chrome-e2e-dapp:
runs-on: dapp-runner-bx
timeout-minutes: 25
needs: [build]
env:
Expand All @@ -319,22 +319,22 @@ jobs:
- uses: ./.github/actions/chromeTestsSetup
with:
gh-access-token: ${{ secrets.DOTENV_GITHUB_ACCESS_TOKEN }}
- name: Run e2e dappInteractions (Chrome)
id: ChromeE2EDappInteractions
- name: Run e2e dapp (Chrome)
id: ChromeE2EDapp
continue-on-error: true
run: |
export BROWSER=chrome
export OS=linux
export CHROMIUM_BIN=$(find chrome -type f -name 'chrome')
yarn vitest:dappInteractions
yarn vitest:dapp
- name: Upload deps artifacts
if: steps.ChromeE2EDappInteractions.outcome == 'failure'
if: steps.ChromeE2EDapp.outcome == 'failure'
uses: actions/upload-artifact@v3
with:
name: screenshots
path: screenshots/
- name: Fail if any tests failed
if: steps.ChromeE2EDappInteractions.outcome == 'failure'
if: steps.ChromeE2EDapp.outcome == 'failure'
run: exit 1
# BRAVE TESTS
# brave-e2e:
Expand Down Expand Up @@ -454,7 +454,7 @@ jobs:
run: yarn typecheck
cleanup:
runs-on: ubuntu-latest
needs: [firefox-e2e-parallel, firefox-e2e-send, firefox-e2e-dappInteractions, chrome-e2e-parallel, chrome-e2e-swap, chrome-e2e-send, chrome-e2e-dappInteractions, chrome-optimism-e2e-send, unit-tests, ci-checks]
needs: [firefox-e2e-parallel, firefox-e2e-send, firefox-e2e-dapp, chrome-e2e-parallel, chrome-e2e-swap, chrome-e2e-send, chrome-e2e-dapp, chrome-e2e-networks, unit-tests, ci-checks]
steps:
- uses: geekyeggo/delete-artifact@v2
with:
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ let driver: WebDriver;
const browser = process.env.BROWSER || 'chrome';
const os = process.env.OS || 'mac';

describe.runIf(browser !== 'firefox')('App interactions flow', () => {
describe.runIf(browser !== 'firefox')('dApp flow', () => {
beforeAll(async () => {
driver = await initDriverWithOptions({
browser,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const browser = process.env.BROWSER || 'chrome';
const os = process.env.OS || 'mac';
const shortenedAddress = shortenAddress(TEST_VARIABLES.SEED_WALLET.ADDRESS);

describe.runIf(browser !== 'firefox')('App interactions flow', () => {
describe.runIf(browser !== 'firefox')('dApp flow', () => {
beforeAll(async () => {
driver = await initDriverWithOptions({
browser,
Expand Down
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
"vitest:serial": "./scripts/e2e-serial-tests.sh",
"vitest:swap": "./scripts/e2e-serial-tests.sh 'swap'",
"vitest:send": "./scripts/e2e-serial-tests.sh 'send'",
"vitest:send:optimism": "./scripts/e2e-op-serial-tests.sh 'optimismTransactions'",
"vitest:dappInteractions": "./scripts/e2e-serial-tests.sh 'dappInteractions'",
"vitest:networks": "./scripts/e2e-networks-serial-tests.sh 'networks'",
"vitest:dapp": "./scripts/e2e-serial-tests.sh 'dapp'",
"e2e:mac:chrome": "BROWSER=chrome OS=mac yarn vitest:parallel && yarn vitest:serial",
"e2e:mac:brave": "BROWSER=brave OS=mac yarn vitest:parallel && yarn vitest:serial",
"e2e:mac:firefox": "yarn firefox:zip && BROWSER=firefox OS=mac yarn vitest:parallel && yarn vitest:serial",
Expand Down
File renamed without changes.