[BX-1423] fix: set max width on app connection wallet switcher names #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
estebanmino
reviewed
Apr 18, 2024
derHowie
force-pushed
the
@chris/wallet-name-overflow
branch
from
e2f2c5f
to
f648349
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
estebanmino
approved these changes
Apr 26, 2024
greg-schrammel
approved these changes
Apr 26, 2024
|
Here's the packed extension for this build: |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Here's the packed extension for this build: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Added a max width to wallet name dropdown to prevent 2 lines
Screen recordings / screenshots
BEFORE:
AFTER:
What to test
Make a really long wallet name, then make sure the dropdown still displays within a single line