Fix backup reminder shortcuts #1454
Conversation
|
@DanielSinclair want some product feedback here. There are some implications on whether we want this to impact other modals (like token expanded state) as well as the backup reminders. |
|
Here's the packed extension for this build: |
|
@BrodyHughes Just targeting the bottom-presenting modals like Backup Reminders should suffice. The issue was more so that shortcuts and actions were occurring invisibly behind the modal UI. We would still want the global shortcuts like |
| if (inputIsFocused) return; | ||
| if (isModal) return; |
There was a problem hiding this comment.
Poorly named I guess, but these are actually the global shortcuts here. We'd expect w to open the wallet switcher from any of the layer 1 drill-downs
There was a problem hiding this comment.
ok cool cool. I can see what I can do in that case.
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
ight fixed this. there was something weird going on with how we were using useReducer to change the boolean value. i just converted to useState and it works fine. useReducer is pretty unnecessary here anyways. |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
@derHowie if you have a sec to do a code review |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fixes BX-1378
What changed (plus any additional context for devs)
isExplainerSheetclass to determine whether or not the global shortcuts should be activeisExplainerSheet, the.,x.,, etc shortcuts won't work. Only the normal navigation andesc. When the backup reminder is dismissed these will work again.escto close explainersScreen recordings / screenshots
Screen.Recording.2024-04-02.at.4.54.42.PM.mov
What to test
ESCandTABthrough items on the backup reminder.,sglobal shortcuts as well (they shouldn't work now while the backup reminder or explainer modals are up)