Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: report nft shortcuts, nft context menu fixes and Cmd+K bug fixes #1425

Merged
merged 34 commits into from May 14, 2024
Merged

chore: report nft shortcuts, nft context menu fixes and Cmd+K bug fixes #1425

merged 34 commits into from May 14, 2024

Conversation

DanielSinclair
Copy link
Contributor

@DanielSinclair DanielSinclair commented Mar 22, 2024 •
edited by magiziz

Fixes BX-1441, BX-1440, BX-1444
Figma link (if any):

What changed (plus any additional context for devs)

  • NFT shortcut menu doesn't close when interacting with a shortcut (NFT tab in homepage)
  • If a context menu is closed after interaction and you try to click the "C" shortcut, it won't copy user's address, but instead copies token id address still.
  • When displaying NFT's in "grid" mode the Cmd+K doesn't work if you hide the last NFT for the section.
  • Added report NFT feature with hide functionality

Check bug videos below 👇

Screen recordings / screenshots

nft_command_k_bug.mov
nft_fixes.mov

What to test

  • Report NFT feature in NFT tab (homepage and NFT detail page)
  • Make sure shortcuts closes context menu if you start interacting with shortcuts (homepage and NFT detail page)
  • Make sure Cmd+K works after your hide the last NFT when using "grid" section mode
  • Make sure when context menu closes, after you click "C" shortcut it should copy user's address instead of NFT address
  • Test the "R" shortcut for refreshing NFTs and when reporting an NFT through context menu. Both should work

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-75cef3aa4c9cb67c1b420b99b1ba90c067185749.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-fc3711b89081ef7614258a907e5711ecf0d2b982.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0f764102b8e474665ad5600f50933c7221979691.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d478e54708fe15fa2e39e6842e6621cfb54dbb42.zip
screenshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-15016e2f7c5ee3ba989984f948390d86677e8ed8.zip

@DanielSinclair
Copy link
Contributor Author

cc @magiziz Looks like we have a merge conflict here

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-fdc6a29dd577a7433b9b49c814ed2cc5e51f6b94.zip

@magiziz
Copy link
Contributor

magiziz commented Apr 18, 2024

@DanielSinclair Fixed merge conflicts 🙏

@DanielSinclair DanielSinclair marked this pull request as ready for review April 24, 2024 05:43
@DanielSinclair DanielSinclair changed the title feat: report nft shortcuts feat: report nft shortcuts, nft context menu fixes Apr 24, 2024
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-51eb3ba1b5c90e516b3c85584d8ec60b07eca02e.zip

@DanielSinclair
Copy link
Contributor Author

@magiziz Fixes are looking good, but spotted a few other things:

  • Noticed that the cmd key seems to dismiss the NFT Details context menu (noticed while taking a screenshot)
  • The cursor for the Copy item in the NFT Details was originally associated with the Download button, but I think we can remove it
  • There is also a different cursor for the Download button in both NFT context menus (indicating download link); can we default that to the normal pointer cursor?
  • I noticed the Download button in NFT Details sometimes/always triggers 2 downloads when clicking
  • Looks like we're missing a Toast when using the Hide shortcut on the NFT Gallery

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a6ca8ffc897292be560f033b5a352335fe59e969.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-169bc23aa31bb5f8cc337e0bdcebf24766637600

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-53a949b078a8e418d6de98254884c4d56d760525

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-53a949b078a8e418d6de98254884c4d56d760525

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-53a949b078a8e418d6de98254884c4d56d760525

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2a62db4b4db254020cc419d1628d38b94f4cc0c4

@DanielSinclair DanielSinclair added this pull request to the merge queue May 12, 2024
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-2a62db4b4db254020cc419d1628d38b94f4cc0c4

@DanielSinclair DanielSinclair removed this pull request from the merge queue due to a manual request May 12, 2024
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-966507d1a25226df7b35679a8d4b888d3af42e63

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-966507d1a25226df7b35679a8d4b888d3af42e63

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-966507d1a25226df7b35679a8d4b888d3af42e63

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-966507d1a25226df7b35679a8d4b888d3af42e63

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b4b8638f2b60fb888ed488b3f0c934b8f9b3b3c2

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-23aecaf79d79c119a9aafc50de0be50e378e70a0

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-23aecaf79d79c119a9aafc50de0be50e378e70a0

@magiziz magiziz added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit 5b4ecac May 14, 2024
17 checks passed
@magiziz magiziz deleted the @daniel/report-nft-cleanup branch May 14, 2024 17:29
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-5b4ecac0c2fb698fb723e39b111a172cb04e3062

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-5b4ecac0c2fb698fb723e39b111a172cb04e3062

DanielSinclair added a commit that referenced this pull request May 14, 2024
@DanielSinclair
Revert "chore: report nft shortcuts, nft context menu fixes and Cmd+K…
bae62c3 
… bug fixes (#1425)"

This reverts commit 5b4ecac.
@DanielSinclair DanielSinclair restored the @daniel/report-nft-cleanup branch May 15, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magiziz magiziz magiziz approved these changes

@BrodyHughes BrodyHughes BrodyHughes approved these changes

@estebanmino estebanmino Awaiting requested review from estebanmino

@derHowie derHowie Awaiting requested review from derHowie

Assignees

@magiziz magiziz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielSinclair @magiziz @BrodyHughes