Refactor font styles for Rails #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirano55
force-pushed
the
refactor_font_styles
branch
2 times, most recently
from
0688a82
to
c7110a8
Compare
yhirano55
force-pushed
the
refactor_font_styles
branch
from
c7110a8
to
775de0f
Compare
|
@robin850 Please code review this PR. How do you feel about this? |
|
@yhirano55 : Hey, sorry I'm not yet sure what we will do with this. We may have a brand new theme for the next release but nothing is sure yet, we need to see. I'll come back to you pretty soon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I feel source codes are not easy to read for us. So I've refactored CSS. Mainly, I changed Typography.
Before
After