golangci-lint: remove the deprecated linters

Also move the move the disabled linters to the enabled list as comments. We will enable them as and when we fix the issues. Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur · Nov 14, 2023 · 3d49e30 · 3d49e30
1 parent 719fd43
commit 3d49e30
Showing 1 changed file with 25 additions and 34 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -41,7 +41,6 @@ linters:
     - bidichk
     - bodyclose
     - cyclop
-    - deadcode
     - decorder
     - depguard
     - dogsled
@@ -61,23 +60,20 @@ linters:
     - gocyclo
     - gofmt
     - gofumpt
-    - golint
     - gomnd
     - gomodguard
     - goprintffuncname
     - gosec
     - gosimple
     - govet
     - grouper
-    - ifshort
     - importas
     - ineffassign
     - interfacebloat
     - lll
     - logrlint
     - maintidx
     - makezero
-    - maligned
     - misspell
     - nakedret
     - nestif
@@ -91,9 +87,7 @@ linters:
     - reassign
     - revive
     - rowserrcheck
-    - scopelint
     - sqlclosecheck
-    - structcheck
     - stylecheck
     - tenv
     - testpackage
@@ -104,35 +98,32 @@ linters:
     - unparam
     - unused
     - usestdlibvars
-    - varcheck
     - wastedassign
     - whitespace
     - wsl
+    # - containedctx
+    # - contextcheck
+    # - errname
+    # - exhaustivestruct
+    # - exhaustruct
+    # - forcetypeassert
+    # - gci
+    # - gochecknoglobals
+    # - gochecknoinits
+    # - godot
+    # - godox
+    # - goerr113
+    # - goheader
+    # - goimports
+    # - gomoddirectives
+    # - interfacer
+    # - ireturn
+    # - nilnil
+    # - nonamedreturns
+    # - paralleltest
+    # - promlinter
+    # - tagliatelle
+    # - varnamelen
+    # - wrapcheck
   disable:
-    - exhaustivestruct
-    - gochecknoglobals
-    - gochecknoinits
-    - godot
-    - godox
-    - paralleltest
-    - goerr113  # TODO: Need to introduce error definition and bring this back
-    - goheader  # TODO: Introduce back post fixing linter errors
-    - gci
-    - interfacer  # interfacer linter is archived and deprecated (https://github.com/mvdan/interfacer)
-    # TODO: fix folloing linter errors.
-    - exhaustruct
-    - tagliatelle
-    - gomoddirectives
-    - goimports
-    - wrapcheck
-    - varnamelen
-    - staticcheck
-    - nosnakecase
-    - ireturn
-    - nilnil
-    - containedctx
-    - nonamedreturns
-    - forcetypeassert
-    - promlinter
-    - contextcheck
-    - errname
+    - staticcheck # Enabled by default, needs explicit disabling. Enable after fixing the issues.